Campbell Barton ideasman42
31 Followers · 0 Following
  • Australia
  • Joined on 2005-01-30
Repositories
5
 Projects Public Activity Starred Repositories
1
Campbell Barton closed pull request blender/blender#128568 2024-10-07 13:00:28 +02:00
Fix #128567: file selector automatically creates paths & warns
Campbell Barton commented on pull request blender/blender#128568 2024-10-07 13:00:24 +02:00
Fix #128567: file selector automatically creates paths & warns

Committed ea2d27cf84d4f6ca0b61f174cac9cfc00656a50f

Campbell Barton suggested changes for blender/blender#128610 2024-10-07 04:35:58 +02:00
Modeling: add support for merging triangles with reference to topology
Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:57 +02:00
Modeling: add support for merging triangles with reference to topology

Use full sentences.

Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:55 +02:00
Modeling: add support for merging triangles with reference to topology

This seems over paranoid - many arguments are assumed to be never-null, asserts are mainly to raise an error for situations that would otherwise silently succeed. Or, to catch errors early that would cause difficult to debug crashes later on.

Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:54 +02:00
Modeling: add support for merging triangles with reference to topology

picky, use bold for emphasis e.g. *solely* , applies to other terms in code-comments too.

Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:53 +02:00
Modeling: add support for merging triangles with reference to topology

Can be replaced with maceo: UNUSED_VARS(s); then the comment isn't needed.

Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:52 +02:00
Modeling: add support for merging triangles with reference to topology

The input will never be null, so this can be replaced with an assert.

Campbell Barton commented on pull request blender/blender#128610 2024-10-07 04:35:50 +02:00
Modeling: add support for merging triangles with reference to topology

May as well use doxy formatted comments for all members /** ... */.

Campbell Barton closed pull request blender/blender#128677 2024-10-07 04:21:36 +02:00
WIP: Various fixes for HOME access
Campbell Barton pushed to main at blender/blender 2024-10-07 04:21:12 +02:00
98002ce4ad Cleanup: minor simplification to file-selector directory expansion
Campbell Barton pushed to main at blender/blender 2024-10-07 04:06:36 +02:00
c1f18be1ba Merge branch 'blender-v4.3-release'
9cda82f3f9 Merge branch 'blender-v4.3-release'
f36b303a75 Merge branch 'blender-v4.3-release'
a5f121149d Merge branch 'blender-v4.3-release'
6039cb17e6 Unix: use getpwuid() to access home when the variable/tilde expand fails
Compare 8 commits »
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-10-07 04:01:59 +02:00
6039cb17e6 Unix: use getpwuid() to access home when the variable/tilde expand fails
1e9206238e Fix crash if expanding the fonts directory fails
ff9d9711d7 Fix crash using "~" in the file selector when the "home" is null
e0f036f8f3 Fix inconsistency between *BKE_appdir_folder_{home/default} on macOS
Compare 4 commits »
Campbell Barton pushed to main at blender/blender 2024-10-07 03:53:34 +02:00
262d32b694 Cleanup: improve comments & add error checking asserts
Campbell Barton pushed to pr-home-fixes at ideasman42/blender 2024-10-07 03:25:40 +02:00
7afaf2e65b Unix: use getpwuid() to access home when the variable/tilde expand fails
f6322e946d Fix crash if expanding the fonts directory fails
73351d13ef Fix crash using "~" in the file selector when the "home" is null
a4ba0c1e17 Fix inconsistency between *BKE_appdir_folder_{home/default} on macOS
61ea50e9c8 UI: don't resolve // in the file selector for unsaved blend files
Compare 9 commits »
Campbell Barton pushed to main at blender/blender 2024-10-07 03:22:01 +02:00
61ea50e9c8 UI: don't resolve // in the file selector for unsaved blend files
6df7656fca Cleanup: remove redundant call to BLI_path_abs, reduce variable scope
16b839dd5f Docs: expand comments for file selector logic
13fdf34e57 Cleanup: early return from file-selector handlers
Compare 4 commits »
Campbell Barton commented on pull request blender/blender#128677 2024-10-07 03:20:25 +02:00
WIP: Various fixes for HOME access

@blender-bot build

Campbell Barton created pull request blender/blender#128677 2024-10-07 03:19:26 +02:00
WIP: Various fixes for HOME access
Campbell Barton pushed to pr-home-fixes at ideasman42/blender 2024-10-07 03:18:22 +02:00
bf54137aeb Unix: use getpwuid() to access home when the variable/tilde expand fails
0bf16e92b2 Fix crash if expanding the fonts directory fails
d0f24b8506 Fix crash using "~" in the file selector when the "home" is null
abf7ad995f Fix inconsistency between *BKE_appdir_folder_{home/default} on macOS
eb09bf0972 UI: don't resolve // in the file selector for unsaved blend files
Compare 10 commits »
Campbell Barton created branch pr-home-fixes in ideasman42/blender 2024-10-07 03:18:22 +02:00