Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton pushed to pr-abs-path-fix at ideasman42/blender 2024-10-05 08:53:13 +02:00
54a2d24715 Fix C: & / detecting as relative paths
4b6ebc9579 Fix error with select non-manifold when a mesh is in face-mode
e03214f424 Cleanup: use doxy code-command
Compare 3 commits »
Campbell Barton created branch pr-abs-path-fix in ideasman42/blender 2024-10-05 08:53:13 +02:00
Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:48:44 +02:00
Modeling: add support for merging triangles with reference to topology

If this needs to be inlined, add a comment explaining why, otherwise use normal_quad_v3.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:48:42 +02:00
Modeling: add support for merging triangles with reference to topology

picky having code comments phrased as questions tends to make them less clear,

Campbell Barton suggested changes for blender/blender#128610 2024-10-05 03:25:56 +02:00
Modeling: add support for merging triangles with reference to topology

Firstly, this is a welcome additions which users will appreciate.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:54 +02:00
Modeling: add support for merging triangles with reference to topology

picky, for booleans defines that aren't defines by CMake, we often have USE_ as a prefix to differentiate them from defines that represent enum/values... etc.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:53 +02:00
Modeling: add support for merging triangles with reference to topology

While there are cases in Blender where both 0-100 percentages and factors are used, I generally prefer to use 0..1 for influence factors, this property can use PROP_FACTOR with a maximum of 2.0.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:52 +02:00
Modeling: add support for merging triangles with reference to topology

For clarity: instead of checking s.topo_influnce != 0 replace this with a boolean, e.g. s.use_topo_influnce .

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:50 +02:00
Modeling: add support for merging triangles with reference to topology

See related comments to magic numbers, re: .99.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:49 +02:00
Modeling: add support for merging triangles with reference to topology

picky Find -> Calculate, since find typically relates to a lookup/search - where the value may not be found.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:48 +02:00
Modeling: add support for merging triangles with reference to topology

See related comment on defining & commenting magic numbers.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:46 +02:00
Modeling: add support for merging triangles with reference to topology

It's good to define magic numbers and comment them to help others follow the logic.

Campbell Barton commented on pull request blender/blender#128610 2024-10-05 03:25:45 +02:00
Modeling: add support for merging triangles with reference to topology

Since the code in this function requires const-cast, it's better not to make them const.

Campbell Barton commented on pull request blender/blender#128493 2024-10-05 02:10:05 +02:00
Modeling: Support selecting elements by pole count

Incidentally this PR prompted a more general cleanup: 093a3abbd42d978dec25d9255b5e08cfd2a0c6fd As some of the issues mentioned in review were found in other operators.

Campbell Barton commented on pull request blender/blender#128033 2024-10-05 02:05:27 +02:00
Fix #128018: BMesh: Single vert selection history for box/circle/lasso

Indeed, there is such kind of a problem in software that set box selection by default - workflow-wise box selection blocks picking actions, delimiting them by threshold, and thresholds is not…

Campbell Barton commented on pull request blender/blender#128493 2024-10-04 09:53:45 +02:00
Modeling: Support selecting elements by pole count

Committed to main, made some minor changes, skip hidden vertices & replace magic numbers with the enum ID's.

Campbell Barton pushed to main at blender/blender 2024-10-04 09:52:18 +02:00
7fcf043f60 Merge branch 'blender-v4.3-release'
4b6ebc9579 Fix error with select non-manifold when a mesh is in face-mode
Compare 2 commits »