Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#104876 2023-03-28 13:17:55 +02:00
Python: Support multiple custom script directories in Preferences

Prefer this be removed as scripts that use it will have incorrect behavior.

Campbell Barton commented on pull request blender/blender#104876 2023-03-28 13:17:55 +02:00
Python: Support multiple custom script directories in Preferences

Rather not warn as in the rare case a user runs into this - it's not as if there is anything to "fix", besides the script author adding explicit checks for "DEFAULT" which isn't useful.

Campbell Barton commented on pull request blender/blender#104876 2023-03-28 13:17:55 +02:00
Python: Support multiple custom script directories in Preferences

The name should be initialized (suggest "Untitled" ?) - otherwise no strong preference, just don't leave it blank.

Campbell Barton reopened issue blender/blender#102985 2023-03-28 08:27:45 +02:00
Wayland: Unable to lower windows
Campbell Barton commented on issue blender/blender#102985 2023-03-28 08:27:43 +02:00
Wayland: Unable to lower windows

@eszlari added support for xdg-activation, although lowering windows still isn't supported (updated task).

Campbell Barton pushed to main at blender/blender 2023-03-28 08:08:02 +02:00
a88c77eaac Cleanup: use struct comments for gwl_registry_handlers declaration
Campbell Barton pushed to main at blender/blender 2023-03-28 08:02:31 +02:00
1cf2ad8e15 Fix #106203: Memory leak with dynamics enabled in particle edit mode
Campbell Barton closed issue blender/blender#106203 2023-03-28 08:02:30 +02:00
Memory leak with dynamics enabled in particle edit mode
Campbell Barton opened issue blender/blender#106203 2023-03-28 07:56:36 +02:00
Memory leak in particle edit mode
Campbell Barton closed issue blender/blender#102985 2023-03-28 07:45:09 +02:00
Wayland: Unable to lower windows
Campbell Barton pushed to main at blender/blender 2023-03-28 07:45:09 +02:00
3071ec486b GHOST/Wayland: support window activation
8132b4a927 GHOST/Wayland: GWL_Seat::data_source_serial when modifiers are set
4ee705ca4f Cleanup: use a system method to access the APP_ID
10b03e66b9 Cleanup: remove unreachable code
4bead379c6 Cleanup: remove redundant (void) in C++ function declarations
Compare 11 commits »
Campbell Barton approved blender/blender#105977 2023-03-27 03:44:55 +02:00
UV: Add alpaca_rotate variant for improved packing efficiency

Approve, with request for a commit message body and some doc-strings.

Campbell Barton commented on pull request blender/blender#105977 2023-03-27 03:43:44 +02:00
UV: Add alpaca_rotate variant for improved packing efficiency

update_hole_rotate doesn't have a doc-string, a short explanation explaining what it's doing would be good. It's not totally obvious that q and quad_area will never be negative, that could be asserted, it could also be noted that the arguments are ordered. (to ensure unexpected negative values never occur).

Campbell Barton commented on pull request blender/blender#105977 2023-03-27 03:43:19 +02:00
UV: Add alpaca_rotate variant for improved packing efficiency

While this commit looks like a nice improvement, please add a description unless the subject includes all necessary information.

I can assume this rotates islands when the faster alpaca method…

Campbell Barton pushed to main at blender/blender 2023-03-27 03:09:44 +02:00
bb2dc141f2 Cleanup: spelling in comments
Campbell Barton closed pull request blender/blender#106158 2023-03-27 02:10:40 +02:00
WIP: GHOST: replace callbacks with a capability flag
Campbell Barton commented on pull request blender/blender#106158 2023-03-27 02:10:39 +02:00
WIP: GHOST: replace callbacks with a capability flag

Committed 4e51008a826f178171a510126e905495c6f78a45, closing.

Campbell Barton pushed to main at blender/blender 2023-03-27 02:08:21 +02:00
99d7816d06 Cleanup: suppress clang-tidy warnings in GHOST_Types.h
Campbell Barton pushed to main at blender/blender 2023-03-27 02:01:41 +02:00
4e51008a82 GHOST: replace multiple functions with a single capabilities flag