Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton suggested changes for blender/blender#104678 2023-03-10 01:40:13 +01:00
UI: File Save Incremental Operator

Testing this patch, noted issues inline.

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:13 +01:00
UI: File Save Incremental Operator

Numbers greater than INT_MAX currently behave strangely. Instead of incrementing the number they return 0 for num and add .

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:13 +01:00
UI: File Save Incremental Operator

Again, doesn't mention incrementing doesn't overwrite.

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:13 +01:00
UI: File Save Incremental Operator

Misses an important point that the name is incremented to the next unused file, never overwriting existing files.

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:12 +01:00
UI: File Save Incremental Operator

This could be removed? (as far as I can see this isn't used), if it is used it could follow the operator name. Save Blender File (Incremental).

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:12 +01:00
UI: File Save Incremental Operator

picky avoiding int-overflow be done at the same time as avoiding too many attempts.

Campbell Barton commented on pull request blender/blender#104678 2023-03-10 01:40:12 +01:00
UI: File Save Incremental Operator

Use enabled otherwise this is still clickable (which isn't expected for greyed out menu items).

Campbell Barton commented on pull request blender/blender#105355 2023-03-10 00:31:15 +01:00
UI: Add scroll to sidebar tabs

Couldn't this be more efficient?

Campbell Barton suggested changes for blender/blender#105355 2023-03-10 00:27:07 +01:00
UI: Add scroll to sidebar tabs
Campbell Barton commented on pull request blender/blender#105355 2023-03-10 00:27:07 +01:00
UI: Add scroll to sidebar tabs

Use ED_region_panel_category_gutter_isect_xy or add a new public utility function to area_query.c if existing functions cannot be used - with an explanation for how it differs from existing intersection checking functions.

Campbell Barton commented on pull request blender/blender#105355 2023-03-10 00:27:06 +01:00
UI: Add scroll to sidebar tabs

Include a comment for shy checking CTRL is needed, also shouldn't this check event->modifier == KM_CTRL (so other modifier combinations are ignored).

Campbell Barton commented on pull request blender/blender#105355 2023-03-10 00:27:06 +01:00
UI: Add scroll to sidebar tabs

Doc-string should state what unit this is in.

Campbell Barton commented on issue blender/blender#105583 2023-03-09 23:51:09 +01:00
Regression: weld multiple polygons crashes in 3.5

@PratikPB2123 my bad, uploaded file.

Campbell Barton suggested changes for blender/blender#104888 2023-03-09 06:48:02 +01:00
Gizmo: add undo and name

In general this works well, however I'd prefer to support undo in a way that's closer to how buttons work (where the information for undo is automatically extracted).

Campbell Barton opened issue blender/blender#105583 2023-03-09 06:12:22 +01:00
Regression: weld multiple polygons crashes in 3.5
Campbell Barton commented on pull request blender/blender#105355 2023-03-09 06:03:25 +01:00
UI: Add scroll to sidebar tabs

Use win->eventstate, win->event_last_handled is intended for event handling logic and not to be used by interface logic. Updated the doc-string to note this 09ba0210d9a19a2713fa0f92cf5f54914789c62f.

Campbell Barton pushed to main at blender/blender 2023-03-09 06:02:29 +01:00
9d3edb7e9a Cleanup: clear the linked list pointers for wmWindow::event_last_handled
09ba0210d9 Docs: note wmWindow::event_last_handled is for event queue handling only
Compare 2 commits »
Campbell Barton pushed to main at blender/blender 2023-03-09 04:54:00 +01:00
434526f3fc Cleanup: use doxy sections
39ab104761 Cleanup: remove invalid copy-pasted comments
Compare 2 commits »
Campbell Barton commented on issue blender/blender#105046 2023-03-09 03:46:44 +01:00
Regression: Inverting face selection now very slow

@HooglyBoogly I'll check on this, if it's simply the compacting the array that's slow, I'll check on optimizing this.

Campbell Barton opened issue blender/blender#105579 2023-03-09 03:39:31 +01:00
Regression: weld polygons crashes in 3.5