Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton pushed to pr-workaround-win11-modifiers at ideasman42/blender 2023-03-02 04:00:04 +01:00
4de4fdd982 WIP workaround bug for mouse press events having wrong modifiers on WIN11
6b8cdd5979 Fix #103469: Update UV Sphere Projection with Seam support.
7de2f21001 Fix: Debug build error after recent variable rename cleanup
3022a805ca Cleanup: Standardize mesh edge and poly naming
0f61497e20 Cleanup: Use spans for mesh render data
Compare 10 commits »
Campbell Barton commented on pull request blender/blender#105263 2023-03-01 23:23:54 +01:00
BLI: Prevent Overflow in Grouped Number Output

Should be BLI_STR_FORMAT_INT32_INTEGER_UNIT_SIZE

Campbell Barton approved blender/blender#105263 2023-03-01 23:23:54 +01:00
BLI: Prevent Overflow in Grouped Number Output

Looks good, it also makes sense to have tests these functions are working as expected (passing in min/max for each type, ensuring values aren't clipped).

Campbell Barton pushed to GroupedOverflow at Harley/blender 2023-03-01 23:08:46 +01:00
39482f0bd9 Using defines for all the formatted string buffer sizes
3022a805ca Cleanup: Standardize mesh edge and poly naming
0f61497e20 Cleanup: Use spans for mesh render data
f1f47df56b Cleanup: Remove unused variable
2324eb4f8c Fix: Use of uninitialized variable after recent cleanup
Compare 11 commits »
Campbell Barton pushed to main at blender/blender 2023-03-01 14:39:47 +01:00
565acb639c WM: use the window associated with an area for initialization
124b41a877 Cleanup: unused variables
Compare 2 commits »
Campbell Barton pushed to main at blender/blender 2023-03-01 12:46:51 +01:00
66c9c19466 Cleanup: add missing CMake headers & sort file lists
Campbell Barton pushed to main at blender/blender 2023-03-01 12:20:50 +01:00
01e711749b pyproject: remove tools/pyproject.toml
e1ab9e352c Cleanup: autopep8
Compare 2 commits »
Campbell Barton pushed to main at blender/blender 2023-03-01 12:03:01 +01:00
bd0aa88909 Fix invalid path references after moving tools & scripts
Campbell Barton pushed to main at blender/blender 2023-03-01 11:17:23 +01:00
e35afd8a1d Merge branch 'blender-v3.5-release'
e9fefcd298 Merge branch 'blender-v3.5-release'
ff89dfd6d2 Fix #105328: unit system does not affect cavity
52064bf5da Fix #104824: GPencil natural drawing building with 1 subdivision very slow
Compare 4 commits »
Campbell Barton closed issue blender/blender#105328 2023-03-01 11:17:22 +01:00
unit system does not affect cavity
Campbell Barton pushed to blender-v3.5-release at blender/blender 2023-03-01 11:15:53 +01:00
ff89dfd6d2 Fix #105328: unit system does not affect cavity
Campbell Barton suggested changes for blender/blender#105263 2023-03-01 08:41:24 +01:00
BLI: Prevent Overflow in Grouped Number Output

Showing ? seems like a bug from a user perspective, if this were unavoidable it could be an acceptable fallback however increasing the default buffer size to fit the largest uint64_t would be preferable.

Campbell Barton approved blender/blender#104746 2023-03-01 08:21:08 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

Minor requests inline, no need for an additional review iteration.

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:08 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

picky can be declared in the for loop.

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:07 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

picky no space before newline needed.

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:07 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

picky is None / is not None (autopep8 even makes this change automatically).

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:07 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

picky NULL, }; to reduce right shift.

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:07 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

literal quoted values should need to be double-back-tick quoted.

Campbell Barton commented on pull request blender/blender#104746 2023-03-01 08:21:07 +01:00
Add a basic support to BKE library linking code to generate liboverrides.

picky only 3 additional spaces of indentation is required.