Code in the body of this function accounts for link being false & create_liboverrides being true. e.g.
The new arguments are missing from the declaration which currently reads.
It's a bit odd to call this function even when create_liboverrides isn't set.
create_runtime reads ambiguously and doesn't obviously relate to library-overrides.
BM_mesh_elem_hflag_disable_all(bm, BM_FACE, BM_ELEM_TAG, false); can be used here.
Is there any reason not to use a single vector (storing a Face pointer and branch value for each item)? Avoids having to keep the arrays in sync and I'd expect would read better.
The way this is used as an argument and re-assigned I find a bit confusing, could call const float branch_init, then use branch for values inline.
The patch should include a user-level description on how this works, some comments inline, otherwise I don't see a need for extra review iterations.
use UVPackIsland_Params params{}; to avoid uninitialized variables if some assignments are omitted.
Resolved soon after but missed this report, closing. fc9c818531d8684d8fc35e0ee91f46afff507f0e
@fclem it looks as if this might be a matter of using the distance subtype for this property.
diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_sc…Updated the patch:
- Add filepath argument to existing load/save pre/post handlers.
- Add
failedargument forposthandlers. - Removed init/failed handlers.
