Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#128224 2024-10-01 01:36:50 +02:00
Abandoned: Refactor join_triangles operator

The macro name isn't all that descriptive, suggest something like:

Campbell Barton commented on pull request blender/blender#128224 2024-10-01 01:36:48 +02:00
Abandoned: Refactor join_triangles operator

By convention, #ifndef NDEBUG is used instead of checking for _DEBUG.

Campbell Barton commented on pull request blender/blender#128224 2024-10-01 01:33:43 +02:00
Abandoned: Refactor join_triangles operator

Please leave unrelated function renaming out of this PR.

Campbell Barton commented on pull request blender/blender#128224 2024-10-01 01:33:42 +02:00
Abandoned: Refactor join_triangles operator

Scripts may use tagging, please use existing flags instead of changing how tagging is done.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 15:11:30 +02:00
Python API: Add link/append pre/post handlers.

Other option would be to find a better generic terminology covering that whole area, but 'Import' is already taken for external formats...

For more generic naming, including the term blend

Campbell Barton commented on issue blender/blender#128175 2024-09-30 15:05:00 +02:00
WIN32: Extension update failed and removed the addon instead

From looking into this it seems likely something has one or more files open within the extensions directory that causes removal to fail.

Even if Blender has permissions to delete the directory,…

Campbell Barton suggested changes for blender/blender#126593 2024-09-30 14:41:14 +02:00
Edit Mode: Add Iterations to Select More/Less

The functionality seems fine, however this will call the region_extend BMesh operator multiple times, please make the repeat argument part of bmo_region_extend_def, so the action can be implemented in bmo_region_extend_expand & bmo_region_extend_contract.

Campbell Barton commented on pull request blender/blender#128224 2024-09-30 10:30:56 +02:00
Abandoned: Refactor join_triangles operator

This will perform multiple reports when multiple meshes are in edit-mode, this kind of change can probably be moved into it's own PR.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:44:04 +02:00
Python API: Add link/append pre/post handlers.

Generally looks good, notes inline.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:44:03 +02:00
Python API: Add link/append pre/post handlers.

It'd be interesting to know if script authors would find it useful to separate: link & append.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:44:02 +02:00
Python API: Add link/append pre/post handlers.

The name seems a bit off, it can't be items because of naming collisions with Python, but the array suffix is also a bit odd (as this is a collection).

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:44:01 +02:00
Python API: Add link/append pre/post handlers.

It looks like this shouldn't be treated as a flag based on it's use elsewhere.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:44:00 +02:00
Python API: Add link/append pre/post handlers.

In RNA we don't typically call these flags as that relates to bit-masks which don't make sense when called from Python, suggest options as we have for bpy.types.Operator & bpy.props.*.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:58 +02:00
Python API: Add link/append pre/post handlers.

picky can be memcpy, but

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:57 +02:00
Python API: Add link/append pre/post handlers.

The linked_appended_* prefix reads poorly to me. We could just call this id ? (it looks to be the primary ID which would be referenced), other ID's can be clarified with longer names.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:56 +02:00
Python API: Add link/append pre/post handlers.

Instead of exposing all of these in one collection, we could expose them by type, similar to Main & library linking/appending API's.

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:55 +02:00
Python API: Add link/append pre/post handlers.

picky can be memcpy, but

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:53 +02:00
Python API: Add link/append pre/post handlers.

Could call this name & type ? (the id_ prefix seems a bit redundant).

Campbell Barton commented on pull request blender/blender#128279 2024-09-30 07:43:52 +02:00
Python API: Add link/append pre/post handlers.

Prefer filepath for consistency, making it clear this isn't related to other kinds of paths.