• Joined on 2024-07-06
il4n created branch il-retiming-reset-update-range in il4n/blender 2024-07-15 23:10:50 +02:00
il4n pushed to il-retiming-reset-update-range at il4n/blender 2024-07-15 23:10:50 +02:00
d0c07f74fe Fix: Reset retiming doesn't update effect strip and meta strip ranges
il4n created pull request blender/blender#124748 2024-07-15 23:06:49 +02:00
WIP: Refactor: Move code into new SEQ_retiming_reset function
il4n created branch il-retiming-reset-refactor in il4n/blender 2024-07-15 23:03:49 +02:00
il4n pushed to il-retiming-reset-refactor at il4n/blender 2024-07-15 23:03:49 +02:00
e1ac582039 Refactor: Move code into new SEQ_retiming_reset function
il4n pushed to il-retiming-reset-overlap-fix at il4n/blender 2024-07-15 22:56:30 +02:00
95fd2b6b44 Fix: VSE: Overlap when using reset retiming on strip with effect strips
f4a4e7f77a Fix: Reset retiming doesn't update effect strip and meta strip ranges
b9882fe4a6 Refactor: Move code into new SEQ_retiming_reset function
Compare 3 commits »
il4n created branch il-retiming-reset-overlap-fix in il4n/blender 2024-07-15 22:56:30 +02:00
il4n created pull request blender/blender#124744 2024-07-15 21:32:34 +02:00
Fix: VSE: Memory leak in SEQ_retiming_data_clear
il4n created branch il-retiming-reset-memory-leak in il4n/blender 2024-07-15 21:29:44 +02:00
il4n pushed to il-retiming-reset-memory-leak at il4n/blender 2024-07-15 21:29:44 +02:00
4468d242c4 Fix: VSE: Memory leak in SEQ_retiming_data_clear
41430ed4bd Cleanup: Split strip foreground drawing function
7a6a2519c5 Refactor: SubdivCCG: Extract utility method for boundary calculation
7fea77992c Fix: Sculpt: Restore transform symmetry clipping lost in refactor
39c334582b Sculpt: Data oriented refactor for nearest vertex search
Compare 10 commits »
il4n deleted branch il-retime-overlap from il4n/blender 2024-07-15 12:19:12 +02:00
il4n deleted branch il-retiming-key-overlap from il4n/blender 2024-07-15 12:15:25 +02:00
il4n deleted branch il-set-speed-overlap from il4n/blender 2024-07-15 12:13:56 +02:00
il4n deleted branch il-transform-tint from il4n/blender 2024-07-15 12:11:46 +02:00
il4n commented on pull request blender/blender#124424 2024-07-10 08:06:56 +02:00
Fix: VSE: Moving a retiming key above a strip would cause overlapping

Yeah I agree, the code confused me as well. I think the issue is because of the if (selected) before the else if(...) statement for it. You can't transform an active non-selected strip, so…

il4n pushed to il-retiming-key-overlap-2 at il4n/blender 2024-07-09 23:48:20 +02:00
3b19efd058 Remove unnecessary includes.
il4n commented on pull request blender/blender#124424 2024-07-09 23:40:20 +02:00
Fix: VSE: Moving a retiming key above a strip would cause overlapping

This is another PR for #124332

il4n pushed to il-retiming-key-overlap-2 at il4n/blender 2024-07-09 23:34:45 +02:00
303b01dddf Much simpler implementation of #visible_strips_ordered_get
78db550b31 Draw ordering of the strips using Richard's code.
Compare 2 commits »
il4n commented on pull request blender/blender#124332 2024-07-09 23:05:11 +02:00
Fix: VSE: Moving a retiming key above a strip would cause overlapping

Testing it, I noticed that that doesn't work with dependent effect strips. Something like this would be very simple, though I'm not sure if it's too risky for this bug fix:

static void
il4n commented on pull request blender/blender#124332 2024-07-09 20:55:02 +02:00
Fix: VSE: Moving a retiming key above a strip would cause overlapping

Something like this would work, but I am not proud of this code

I'd personally prefer having something like a strip_has_selected_retiming_keys function and do it the same way it is done for…