infrastructure/blender-buildbot-www
1
0
Fork 2
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add support for alternative download domain #3

Merged
Francesco Siddi merged 4 commits from cdn-support-for-downloads into develop 2024-05-30 09:22:56 +02:00
Conversation 0 Commits 4 Files Changed 1 +6 -4
Francesco Siddi commented 2024-05-29 19:19:27 +02:00
Owner
Copy Link

This change facilitates the introduction of a CDN to serve files under the /download path.

When constructing the download url in getFileNameURL, look for a DOWNLOAD_FILE_DOMAIN env variable, and use it to construct the download url for a build. If the env variable is not set, the existing host is used (current behavior).

This change facilitates the introduction of a CDN to serve files under the /download path. When constructing the download url in getFileNameURL, look for a DOWNLOAD_FILE_DOMAIN env variable, and use it to construct the download url for a build. If the env variable is not set, the existing host is used (current behavior).
Francesco Siddi added 3 commits 2024-05-29 19:19:28 +02:00 
Prevent browsing the site when HOST_CDN is set and HTTP_HOST matches it.
Sergey Sharybin requested changes 2024-05-29 19:28:59 +02:00
Dismissed
Sergey Sharybin left a comment
Owner
Copy Link

I don't fully understand how the setup is supposed to work.
But even without going that the implementation seems to be inconsistemt.

I don't fully understand how the setup is supposed to work. But even without going that the implementation seems to be inconsistemt.
source/BuildsRenderer.php
@ -289,3 +287,3 @@
$protocol = "https";
$host_id = getHostId();
$env_id = getEnvId();
Sergey Sharybin commented 2024-05-29 19:27:15 +02:00
Owner
Copy Link

The environment ID depends on getHostId(). If the host ID is somehow to depend on configuration, it needs to be consistently handled in getHostId()

The environment ID depends on `getHostId()`. If the host ID is somehow to depend on configuration, it needs to be consistently handled in `getHostId()`
Francesco Siddi added 1 commit 2024-05-29 20:58:42 +02:00
Francesco Siddi changed title from Add support for CDN downloads to Add support for alternative download origin 2024-05-29 20:59:50 +02:00
Francesco Siddi changed target branch from master to develop 2024-05-29 21:00:38 +02:00
Francesco Siddi changed title from Add support for alternative download origin to Add support for alternative download domain 2024-05-29 21:10:28 +02:00
Sergey Sharybin approved these changes 2024-05-29 21:15:16 +02:00
Francesco Siddi merged commit 7a0a36c304 into develop 2024-05-30 09:22:56 +02:00
Francesco Siddi deleted branch cdn-support-for-downloads 2024-05-30 09:23:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-buildbot-www#3
No description provided.
Delete Branch "cdn-support-for-downloads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?