Docker: Describe and add Docker compose setup for local development #8
No reviewers
Labels
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/blender-buildbot-www#8
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "docker-compose"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If found useful, for quick local development, we can utilize Docker.
The thoughts behind not including the docker file were:
From my understanding using
ports: 80:80
will interfere with possible other sites running on the developer machine. And there is no comment about it (although, it was also no comment about it before, but with an instruction-like readme it fits more naturally to say "use a different port if you're already using port 80, for example 80:8888". Something that would help avoiding confusion, and would give exact syntax for people who don't run docker on a daily basis.If the docker is how the webteam and devops are running sites anyway, then we can promote it to something more official. But we need to do something with the possible port conflict.
To address some of Sergey's feedback, I suggest to update the readme showing how to override the host port with an environment variable. For the rest, I'm happy to see a docker file as it's the easiest way to run the website on macOS.
2b6cb56637
to65494a5028
I changed the default host port to
8080
and added a way to override it with an environment variable.65494a5028
to1861970d20
Looking good!