infrastructure/blender-buildbot-www
1
0
Fork 2
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Docker: Describe and add Docker compose setup for local development #8

Merged
Bart van der Braak merged 2 commits from docker-compose into master 2024-07-25 09:08:03 +02:00
Conversation 2 Commits 2 Files Changed 4 +32 -13
Bart van der Braak commented 2024-07-16 10:07:42 +02:00
Owner
Copy Link

If found useful, for quick local development, we can utilize Docker.

If found useful, for quick local development, we can utilize Docker.
Bart van der Braak added 1 commit 2024-07-16 10:07:43 +02:00
Sergey Sharybin requested review from Francesco Siddi 2024-07-16 10:15:34 +02:00
Sergey Sharybin requested review from Pablo Vazquez 2024-07-16 10:15:40 +02:00
Sergey Sharybin commented 2024-07-16 10:28:00 +02:00
Owner
Copy Link

The thoughts behind not including the docker file were:

  • It is not how we run Docker in the production, so it is purely limited to the developers.
  • Developers might have different ways how they want things to be run.
  • We don't typically ad things which are too niche or used by a very small group of people.
  • Readme could be much better documented in places where some tweaks are possibly needed to avoid interference with other services running on the developer machine.

From my understanding using ports: 80:80 will interfere with possible other sites running on the developer machine. And there is no comment about it (although, it was also no comment about it before, but with an instruction-like readme it fits more naturally to say "use a different port if you're already using port 80, for example 80:8888". Something that would help avoiding confusion, and would give exact syntax for people who don't run docker on a daily basis.

If the docker is how the webteam and devops are running sites anyway, then we can promote it to something more official. But we need to do something with the possible port conflict.

The thoughts behind not including the docker file were: - It is not how we run Docker in the production, so it is purely limited to the developers. - Developers might have different ways how they want things to be run. - We don't typically ad things which are too niche or used by a very small group of people. - Readme could be much better documented in places where some tweaks are possibly needed to avoid interference with other services running on the developer machine. From my understanding using `ports: 80:80` will interfere with possible other sites running on the developer machine. And there is no comment about it (although, it was also no comment about it before, but with an instruction-like readme it fits more naturally to say "use a different port if you're already using port 80, for example 80:8888". Something that would help avoiding confusion, and would give exact syntax for people who don't run docker on a daily basis. If the docker is how the webteam and devops are running sites anyway, then we can promote it to something more official. But we need to do something with the possible port conflict.
👀 1
Francesco Siddi requested changes 2024-07-17 19:32:30 +02:00
Dismissed
Francesco Siddi left a comment
Owner
Copy Link

To address some of Sergey's feedback, I suggest to update the readme showing how to override the host port with an environment variable. For the rest, I'm happy to see a docker file as it's the easiest way to run the website on macOS.

To address some of Sergey's feedback, I suggest to update the readme showing how to override the host port with an environment variable. For the rest, I'm happy to see a docker file as it's the easiest way to run the website on macOS.
👍 2
Bart van der Braak added 1 commit 2024-07-24 13:02:44 +02:00
Bart van der Braak force-pushed docker-compose from 2b6cb56637 to 65494a5028 2024-07-24 13:10:35 +02:00 Compare
Bart van der Braak commented 2024-07-24 13:11:15 +02:00
Author
Owner
Copy Link

To address some of Sergey's feedback, I suggest to update the readme showing how to override the host port with an environment variable. For the rest, I'm happy to see a docker file as it's the easiest way to run the website on macOS.

I changed the default host port to 8080 and added a way to override it with an environment variable.

> To address some of Sergey's feedback, I suggest to update the readme showing how to override the host port with an environment variable. For the rest, I'm happy to see a docker file as it's the easiest way to run the website on macOS. I changed the default host port to `8080` and added a way to override it with an environment variable.
Bart van der Braak force-pushed docker-compose from 65494a5028 to 1861970d20 2024-07-24 13:13:41 +02:00 Compare
Bart van der Braak requested review from Francesco Siddi 2024-07-24 13:14:35 +02:00
Bart van der Braak requested review from Sergey Sharybin 2024-07-24 13:14:46 +02:00
Francesco Siddi approved these changes 2024-07-24 22:11:51 +02:00
Francesco Siddi left a comment
Owner
Copy Link

Looking good!

Looking good!
Bart van der Braak merged commit 24b6f9c06b into master 2024-07-25 09:08:03 +02:00
Bart van der Braak deleted branch docker-compose 2024-07-25 09:08:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Sergey Sharybin
Francesco Siddi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-buildbot-www#8
No description provided.
Delete Branch "docker-compose"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?