Add support for alternative download domain #3

Merged
Francesco Siddi merged 4 commits from cdn-support-for-downloads into develop 2024-05-30 09:22:56 +02:00

View File

@ -284,15 +284,17 @@ class BuildsRenderer {
stringContains($_SERVER['REQUEST_URI'], "bpy")) ?
"/download/daily" : strtok($_SERVER['REQUEST_URI'], '?');
$env_id = getEnvId();
$protocol = "https";
$host_id = getHostId();
$env_id = getEnvId();
Review

The environment ID depends on getHostId(). If the host ID is somehow to depend on configuration, it needs to be consistently handled in getHostId()

The environment ID depends on `getHostId()`. If the host ID is somehow to depend on configuration, it needs to be consistently handled in `getHostId()`
if (! in_array($env_id, array("UATEST", "PROD"))) {
$protocol = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] === 'on' ? "https" : "http");
}
$uri = $protocol . "://$host_id" . "$request_uri";
// Use specific host provided for file downloads if present, otherwise serve
// files from the same domain as the website itself.
$download_host = getenv('DOWNLOAD_FILE_DOMAIN') ?: getHostId();
$uri = $protocol . "://$download_host" . "$request_uri";
$escaped_file_name = htmlspecialchars($build->file_name);