infrastructure/blender-id
0
4
Fork 0
Code Issues 11 Pull Requests Projects Releases Wiki Activity

User session tracking #93587

Merged
Oleg-Komarov merged 18 commits from user-session into main 2024-08-02 16:04:09 +02:00
Conversation 0 Commits 18 Files Changed 14 +3 -3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1f4e4db0d6 - Show all commits

1
bid_main/models.py
View File

@ -689,5 +689,4 @@ class UserSession(models.Model):
def device(self): def device(self):
if self.user_agent: if self.user_agent:
return user_agents.parse(self.user_agent) return user_agents.parse(self.user_agent)
else:
return None return None
Oleg-Komarov marked this conversation as resolved Outdated
Anna Sirota commented 2024-08-02 11:28:37 +02:00
Outdated
Review
Copy Link

superfluous else

superfluous else

3
bid_main/views/normal_pages.py
View File

@ -448,7 +448,8 @@ class ActiveSessionsView(LoginRequiredMixin, TemplateView):
class TerminateSessionView(LoginRequiredMixin, View): class TerminateSessionView(LoginRequiredMixin, View):
def post(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
if user_session := self.request.user.sessions.filter(pk=kwargs.get('pk', 0)).first(): user_session_pk = kwargs.get('pk')
Oleg-Komarov marked this conversation as resolved Outdated
Anna Sirota commented 2024-08-02 11:40:11 +02:00
Outdated
Review
Copy Link

getting the pk (pk = kwargs['pk']: it's fine to expect it to be present at this point) and filtering the session on the separate line would make this more readable.

getting the `pk` (`pk = kwargs['pk']`: it's fine to expect it to be present at this point) and filtering the session on the separate line would make this more readable.
if user_session := self.request.user.sessions.filter(pk=user_session_pk).first():
user_session.session.delete() user_session.session.delete()
user_session.delete() user_session.delete()
return redirect('bid_main:active_sessions') return redirect('bid_main:active_sessions')