infrastructure/blender-open-data
2
3
Fork 3
Code Issues 15 Pull Requests 1 Projects Releases Wiki Activity

Client: improve error reporting #56372

New Issue
Closed
opened 2018-08-14 09:39:15 +02:00 by Sybren A. Stüvel · 3 comments
Sybren A. Stüvel commented 2018-08-14 09:39:15 +02:00
Owner
Copy Link

Benchmark submission errors are now reported with the Operator.report() function. This has a few downsides:

  • The error is shown in a popup, which disappears after the user moved the mouse too much. Since submission of the benchmark can happen in the background (while the user is still looking at the "you can close me" page in their webbrowser), errors can go unnoticed.
  • Long text isn't wrapped, but rather causes the title of the popup to be invisible (due to being positioned on coordinates outside the window and thus not drawn).

As a possible solution we could avoid the report() function and write the error message to a permanently-shown and word-wrapping UI element. The submission button should also change text, like "Retry Submission" or something along those lines.

Benchmark submission errors are now reported with the `Operator.report()` function. This has a few downsides: - The error is shown in a popup, which disappears after the user moved the mouse too much. Since submission of the benchmark can happen in the background (while the user is still looking at the "you can close me" page in their webbrowser), errors can go unnoticed. - Long text isn't wrapped, but rather causes the title of the popup to be invisible (due to being positioned on coordinates outside the window and thus not drawn). As a possible solution we could avoid the `report()` function and write the error message to a permanently-shown and word-wrapping UI element. The submission button should also change text, like "Retry Submission" or something along those lines.
Sybren A. Stüvel commented 2018-08-14 09:39:15 +02:00
Author
Owner
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Sybren A. Stüvel self-assigned this 2018-08-14 15:05:17 +02:00
blender-admin commented 2018-08-14 15:05:37 +02:00
Copy Link

This issue was referenced by infrastructure/blender-benchmark-bundle@7b88d7704c

This issue was referenced by infrastructure/blender-benchmark-bundle@7b88d7704c222107c6468d88b7eed5a14152796d
Sybren A. Stüvel commented 2018-08-14 15:09:19 +02:00
Author
Owner
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from Developers

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from Developers
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Sybren A. Stüvel
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-open-data#56372
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?