infrastructure
/
blender-org
4
3
Fork 1
Code Issues 6 Pull Requests Projects Releases Wiki Activity

Move Add Comment before 'code diff' in task reviews #37611

New Issue
Closed
opened 2013-11-25 04:05:17 +01:00 by Dalai Felinto · 7 comments
Dalai Felinto commented 2013-11-25 04:05:17 +01:00
Owner
Copy Link

See for example this task:
http://developer.blender.org/D30

If you want to add a commentary that refers to a previous comment, you need to do a lot of scrolling back and forth to read the discussion. I think it would be great if the 'Add Comment' could be right after the existent commentaries.

My 2 cents ...

See for example this task: http://developer.blender.org/D30 If you want to add a commentary that refers to a previous comment, you need to do a lot of scrolling back and forth to read the discussion. I think it would be great if the 'Add Comment' could be right after the existent commentaries. My 2 cents ...
Dalai Felinto commented 2013-11-25 04:05:17 +01:00
Author
Owner
Copy Link

Changed status to: 'Open'

Changed status to: 'Open'
Brecht Van Lommel was assigned by Dalai Felinto 2013-11-25 04:05:17 +01:00
Dalai Felinto commented 2013-11-25 04:05:17 +01:00
Author
Owner
Copy Link

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Dalai Felinto commented 2013-11-25 04:08:44 +01:00
Author
Owner
Copy Link

I just realized the preview below the commentaries + the add commentary tab would take too much space.
Another option is the have a 'hide/show' patch option and leave the comments where they are now. That would mean more work though.

I just realized the preview below the commentaries + the add commentary tab would take too much space. Another option is the have a 'hide/show' patch option and leave the comments where they are now. That would mean more work though.
Brecht Van Lommel commented 2013-11-25 04:29:53 +01:00
Owner
Copy Link

You can press Z key to show the comment area overlapping, which is actually quite nice I think. There's a bunch of other useful shortcuts when pressing the ? key.

You can press Z key to show the comment area overlapping, which is actually quite nice I think. There's a bunch of other useful shortcuts when pressing the ? key.
Brecht Van Lommel commented 2013-11-25 12:38:55 +01:00
Owner
Copy Link

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Brecht Van Lommel commented 2013-11-25 12:38:55 +01:00
Owner
Copy Link

In any case, our purpose is not to develope Phabricator itself, just to do important tweaks for things that Blender needs.

In any case, our purpose is not to develope Phabricator itself, just to do important tweaks for things that Blender needs.
Dalai Felinto commented 2013-11-25 13:36:43 +01:00
Author
Owner
Copy Link

Z is indeed perfect. Thanks Brecht

Z is indeed perfect. Thanks Brecht
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
features_favicon
download-redesign
features
Labels
Clear labels   
legacy module
Rendering & Cycles

  
legacy module
User Interface

  
legacy project
Cycles

  
legacy project
Documentation

  
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
legacy project
User Interface

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Report

  
Type
To Do

No Label
legacy module
Rendering & Cycles
legacy module
User Interface
legacy project
Cycles
legacy project
Documentation
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
legacy project
User Interface
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Brecht Van Lommel
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-org#37611
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?