infrastructure/blender-org
5
4
Fork 1
Code Issues 16 Pull Requests Projects Releases Wiki Activity

[Blender ID] Password confirmation form has design problems. #62268

New Issue
Closed
opened 2019-03-06 16:25:24 +01:00 by Simon G. · 6 comments
Simon G. commented 2019-03-06 16:25:24 +01:00
Copy Link

Reproduction steps

  1. Goto https://www.blender.org/id/register/ fill in values, click register.
  2. Click on the registration link received via email. E.g. https://www.blender.org/id/register/password/MTU4NDE4/54e-124f7cbcdd22610ec862/

Notice how there are overlapping lines and other strange behavior.
Firefox (65.0.1 (64-bit)):
firefox.jpg

Google Chrome Canary74.0.3725.0 (official build) canary (64-Bit):
chrome.jpg

(I'm new to phabricator, so I hope I've added the correct tags etc)

**Reproduction steps** 1. Goto https://www.blender.org/id/register/ fill in values, click register. 2. Click on the registration link received via email. E.g. https://www.blender.org/id/register/password/MTU4NDE4/54e-124f7cbcdd22610ec862/ Notice how there are overlapping lines and other strange behavior. Firefox (65.0.1 (64-bit)): ![firefox.jpg](https://archive.blender.org/developer/F6773545/firefox.jpg) Google Chrome Canary74.0.3725.0 (official build) canary (64-Bit): ![chrome.jpg](https://archive.blender.org/developer/F6773544/chrome.jpg) (I'm new to phabricator, so I hope I've added the correct tags etc)
Simon G. commented 2019-03-06 16:25:24 +01:00
Author
Copy Link

Added subscriber: @intrigus-3

Added subscriber: @intrigus-3
Simon G. commented 2019-03-11 19:10:11 +01:00
Author
Copy Link

Added subscribers: @fsiddi, @pablovazquez

Added subscribers: @fsiddi, @pablovazquez
Francesco Siddi commented 2019-03-13 17:06:10 +01:00
Owner
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Francesco Siddi commented 2019-03-13 17:06:10 +01:00
Owner
Copy Link

Fixed in infrastructure/blender-id@859f87484c, but I would like to ask @dr.sybren to have a look a it as well.

On my development setup, when overriding the password selection view (^register/password/... in bid_main/urls.py) with auth_views.PasswordResetConfirmView.as_view() with the template registration/initial_set_password.html, the default Django template shows up.
We renaming registration/initial_set_password.html to registration/password_reset_confirm.html the template is displayed correctly.

Fixed in infrastructure/blender-id@859f87484c, but I would like to ask @dr.sybren to have a look a it as well. On my development setup, when overriding the password selection view (`^register/password/...` in `bid_main/urls.py`) with `auth_views.PasswordResetConfirmView.as_view()` with the template `registration/initial_set_password.html`, the default Django template shows up. We renaming `registration/initial_set_password.html` to `registration/password_reset_confirm.html` the template is displayed correctly.
Sybren A. Stüvel commented 2019-03-15 11:01:08 +01:00
Owner
Copy Link

The wrong templates being used was my mistaken in ccaef993d6b370007fb433e6aca355351faeb4c4, fixed it now properly in 6e514788f1e58a59030d2d86bd7b2eb608027608 and 2ec1b257b2751f7928fa49bbfb7244be7a7c8dc9.

The initial password form still has bad layout, though:

image.png

The wrong templates being used was my mistaken in ccaef993d6b370007fb433e6aca355351faeb4c4, fixed it now properly in 6e514788f1e58a59030d2d86bd7b2eb608027608 and 2ec1b257b2751f7928fa49bbfb7244be7a7c8dc9. The initial password form still has bad layout, though: ![image.png](https://archive.blender.org/developer/F6828956/image.png)
Francesco Siddi self-assigned this 2019-04-12 12:17:58 +02:00
Francesco Siddi commented 2019-04-12 17:41:00 +02:00
Owner
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
legacy module
Rendering & Cycles

  
legacy module
User Interface

  
legacy project
Cycles

  
legacy project
Documentation

  
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
legacy project
User Interface

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Report

  
Type
To Do

No Label
legacy module
Rendering & Cycles
legacy module
User Interface
legacy project
Cycles
legacy project
Documentation
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
legacy project
User Interface
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Francesco Siddi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-org#62268
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?