Chat: Improve css for threaded conversations #75534

New Issue

Ray molenkamp · 2020-04-08T19:36:27+02:00

Ray molenkamp commented

2020-04-08 19:36:27 +02:00

In an effort to have more open communications we have recently re-enabled threaded conversions, which have been working well, except for the display of threaded talk in the main channel where the messages have lost both the sender and timestamp and displaying just a tiny version of the users avatar. Making conversations less open cause there's no way to tell who is talking (beyond the few high profile users who's avatar people may recognize) or when things were said.

{F8457046, width=100%}

@dfelinto suggested we may be able to fix this in css and asked for a task.

In an effort to have more open communications we have recently re-enabled threaded conversions, which have been working well, except for the display of threaded talk in the main channel where the messages have lost both the sender and timestamp and displaying just a tiny version of the users avatar. Making conversations less open cause there's no way to tell who is talking (beyond the few high profile users who's avatar people may recognize) or when things were said. {[F8457046](https://archive.blender.org/developer/F8457046/image.png), width=100%} @dfelinto suggested we may be able to fix this in css and asked for a task.

Ray molenkamp commented

2020-04-08 19:36:27 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ray molenkamp commented

2020-04-08 19:36:27 +02:00

Added subscribers: @dfelinto, @LazyDodo

Dalai Felinto commented

2020-04-14 19:03:59 +02:00

Added subscribers: @MikeyN, @pablovazquez

Dalai Felinto commented

2020-04-14 19:03:59 +02:00

Hi @pablovazquez can anything be done about that? Maybe something to coordinate with @MikeyN ?

Mike Newbon commented

2020-04-16 12:10:34 +02:00

Adding in a persons name would not just be CSS as the name isnt anywhere in the dom - increasing the Image size, sure. Never looked into the backend of RocketChat but i'm sure it's possible :) Happy to look into it if @pablovazquez doesn't have time.

I thought the point with threads though was that you open the thread on the right and continue the conversation there - where you can see names and timestamps, and the text in chat was just a notification that a new comment has been added to the thread.

Adding in a persons name would not just be CSS as the name isnt anywhere in the dom - increasing the Image size, sure. Never looked into the backend of RocketChat but i'm sure it's possible :) Happy to look into it if @pablovazquez doesn't have time. I thought the point with threads though was that you open the thread on the right and continue the conversation there - where you can see names and timestamps, and the text in chat was just a notification that a new comment has been added to the thread. ![Frame 9.png](https://archive.blender.org/developer/F8476715/Frame_9.png)

Pablo Vazquez commented

2020-04-17 10:06:24 +02:00

In #75534#911116, @MikeyN wrote:
Adding in a persons name would not just be CSS as the name isnt anywhere in the dom

The name is actually in the alt attribute of the image, and also as a custom data-username attribute, so you could use CSS to hide the image and show it as text instead with something like content: attr(alt). It would still be a hack and tricky to get it to work reliable (with long usernames and such).

I don't have time to work on this at the moment, if @MikeyN wants to have a go at it sure, but there is nothing in the backend of RocketChat that allows you to do this, the Threads feature settings is literally one switch:
{F8478271, size=full}

All tweaks are done with pure CSS.

> In #75534#911116, @MikeyN wrote: > Adding in a persons name would not just be CSS as the name isnt anywhere in the dom The name is actually in the `alt` attribute of the image, and also as a custom `data-username` attribute, so you could use CSS to hide the image and show it as text instead with something like `content: attr(alt)`. It would still be a hack and tricky to get it to work reliable (with long usernames and such). I don't have time to work on this at the moment, if @MikeyN wants to have a go at it sure, but there is nothing in the backend of RocketChat that allows you to do this, the Threads feature settings is literally one switch: {[F8478271](https://archive.blender.org/developer/F8478271/image.png), size=full} All tweaks are done with pure CSS.

Pablo Vazquez commented

2022-05-09 16:51:46 +02:00

Is this 2-year old task still relevant? If not then it can be closed.

Dalai Felinto commented

2022-05-09 18:20:56 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Dalai Felinto closed this issue

2022-05-09 18:20:56 +02:00

Dalai Felinto self-assigned this 2022-05-09 18:20:56 +02:00

Dalai Felinto commented

2022-05-09 18:20:56 +02:00

Asking for forgiveness instead of asking for permission :) Closing, it can be re-opened if still relevant.

Sign in to join this conversation.

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-org#75534

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Chat: Improve css for threaded conversations #75534