infrastructure/blender-org
5
4
Fork 1
Code Issues 16 Pull Requests Projects Releases Wiki Activity

Blender-org web-assets v2 upgrade #104116

Merged
Márton Lente merged 56 commits from web-assets-v2-upgrade into main 2024-08-13 17:27:59 +02:00
Conversation 4 Commits 56 Files Changed 39 +18 -3
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6517a2bf78 - Show all commits

19
themes/bthree/src/styles/_base.sass
View File

@ -1,8 +1,8 @@
\:root \:root
--fs-xl: 3.6rem --fs-xl: 6.4rem
+media-sm +media-sm
--fs-xl: 3.2rem --fs-xl: 5.6rem
$page-card-icon-size: 7.8rem $page-card-icon-size: 7.8rem
martonlente marked this conversation as resolved Outdated
Pablo Vazquez commented 2024-08-05 18:01:13 +02:00
Outdated
Review
Copy Link

Can this be a CSS variable instead of Sass?

Can this be a CSS variable instead of Sass?
.page-card .page-card
@ -424,3 +424,18 @@ body.is-lightbox-active
/* Web Assets Overrides. TODO: move to separate partial */ /* Web Assets Overrides. TODO: move to separate partial */
.cards-item-title .cards-item-title
font-size: var(--fs-h4) font-size: var(--fs-h4)
details
border-radius: var(--border-radius-lg)
p,
ul
+padding(5, x)
Pablo Vazquez commented 2024-08-05 18:03:53 +02:00
Outdated
Review
Copy Link

I don't think we need this anymore? We've got _details.sass in web-assets.

I don't think we need this anymore? We've got _details.sass in web-assets.
Márton Lente commented 2024-08-06 11:28:47 +02:00
Outdated
Review
Copy Link

We currently use details on e.g. System Requirements page on blender.org (and on other pages with a similar look). As details blocks are top level blocks that are displayed as other boxes on the page, this is a way to keep current styling on the theme level, without introducing the need for database-level content changes.

Alternatively we can remove style overrides from the theme, and make content changes in the Gutenberg editor (by adding grouping elements with the box class). I'd suggest to keep it like this, and apply content changes and do styles' cleanup in a next iteration.

We currently use `details` on e.g. [System Requirements](https://www.blender.org/download/requirements) page on blender.org (and on other pages with a similar look). As details blocks are top level blocks that are displayed as other boxes on the page, this is a way to keep current styling on the theme level, without introducing the need for database-level content changes. Alternatively we can remove style overrides from the theme, and make content changes in the Gutenberg editor (by adding grouping elements with the `box` class). I'd suggest to keep it like this, and apply content changes and do styles' cleanup in a next iteration.
summary
+padding(3)
+padding(5, left)
&:before
left: var(--spacer)
top: var(--spacer)

2
themes/bthree/src/styles/_features.sass
View File

@ -167,7 +167,7 @@
.cards-item-content .cards-item-content
.cards-item-title .cards-item-title
font: font:
size: var(--fs-5) size: var(--fs-h2)
weight: normal weight: normal
.cards-item-label .cards-item-label