Buildbot: needs-package-delivery implicitly sets need-gpu-binaries #101

New Issue

Bart van der Braak · 2024-07-26T12:34:52+02:00

2024-07-26 12:34:52 +02:00

Julian reported that needs_package_delivery will also automatically mean needs_gpu_binaries but this is not transparent to the user in Buildbot since it won't be part of its build configuration:

    if step_name in ["compile-gpu", "compile-install", "test-code"]:
        if needs_package_delivery or needs_gpu_binaries:
            args += ["--needs-gpu-binaries"]
        if needs_gpu_tests:
            args += ["--needs-gpu-tests"]

Example: https://builder.blender.org/admin/#/builders/136/builds/6107

Julian reported that `needs_package_delivery` will also automatically mean `needs_gpu_binaries` but this is not transparent to the user in Buildbot since it won't be part of its build configuration: ```python if step_name in ["compile-gpu", "compile-install", "test-code"]: if needs_package_delivery or needs_gpu_binaries: args += ["--needs-gpu-binaries"] if needs_gpu_tests: args += ["--needs-gpu-tests"] ``` Example: https://builder.blender.org/admin/#/builders/136/builds/6107

Bart van der Braak added this to the DevOps Progress Board project 2024-07-26 12:34:52 +02:00

Sergey Sharybin commented

2024-07-29 16:33:03 +02:00

Not sure what is the proposed solution, but we should not be delivering downloadble builds without precompiled GPU kernels, as that would be very confusing to people downloading builds. Maybe we can simply improve wording for the time being, to make things clear without functional changes.

Bart van der Braak added the

Service

Buildbot

label 2024-08-01 11:00:09 +02:00

Bart van der Braak added the

Type

Config

label 2024-08-01 11:25:00 +02:00

Bart van der Braak closed this issue

2024-08-14 10:31:30 +02:00

Bart van der Braak reopened this issue

2024-08-14 10:34:49 +02:00