Dark themes rendering issue on Animation & Rigging page: there are still columns with a white background #119

New Issue

xan2622 · 2024-08-13T19:38:34+02:00

xan2622 commented

2024-08-13 19:38:34 +02:00

While using the bthree-dark theme, the Animation & Rigging page: https://projects.blender.org/blender/blender/projects/1 looks incomplete (a few columns still feature a white background).
Note that it also happens if you choose the gitea-dark theme in your user appearance settings.

While using the _bthree-dark_ theme, the Animation & Rigging page: https://projects.blender.org/blender/blender/projects/1 looks incomplete (a few columns still feature a white background). Note that it also happens if you choose the _gitea-dark_ theme in your [user appearance settings](https://projects.blender.org/user/settings/appearance).

Bart van der Braak commented

2024-08-14 10:10:56 +02:00

Hi @xan2622,

I see that these columns have explicitly been set to that color (••• → Edit Column):

Could you elaborate on what the expected behavior is?

Hi @xan2622, I see that these columns have explicitly been set to that color (`•••` → `Edit Column`): <img width="1286" alt="image" src="attachments/3386d0f3-0833-40b3-8e86-3751ab050149"> Could you elaborate on what the expected behavior is?

image.png

113 KiB

Bart van der Braak added the

Service

Gitea

label 2024-08-14 10:16:51 +02:00

Bart van der Braak closed this issue

2024-08-14 10:31:40 +02:00

Bart van der Braak reopened this issue

2024-08-14 10:34:29 +02:00

xan2622 commented

2024-08-14 17:15:56 +02:00

The expected behavior would be that the background color for these columns matches to the other pages of the currently active dark theme (bthree-dark or gitea-dark).

For bthree-dark, I would expect these colors to be at least background-color: var(--color-project-board-bg) !important or like the EEVEE & Viewport / User Interface pages, that the background colors of these columns be compatible with what we are used to see while using a "dark theme".

To compare, here are the other project pages:

USD: https://projects.blender.org/blender/blender/projects/18
Nodes & Physics: https://projects.blender.org/blender/blender/projects/9
Grease Pencil: https://projects.blender.org/blender/blender/projects/6
EEVEE & Viewport: https://projects.blender.org/blender/blender/projects/5 (this page is interesting because it features different columns, each one featuring colors that fit well with the current activated bthree-dark theme)
Sculpt, Paint & Texture: https://projects.blender.org/blender/blender/projects/14
Compositing: https://projects.blender.org/blender/blender/projects/2
Motion Tracking: https://projects.blender.org/blender/blender/projects/8 (this one shows empty columns and despite that state, their background color fits the current activated dark theme)
Python API: https://projects.blender.org/blender/blender/projects/12
Video Sequencer: https://projects.blender.org/blender/blender/projects/17
Platforms, Builds Tests & Devices: https://projects.blender.org/blender/blender/projects/11
User Interface: https://projects.blender.org/blender/blender/projects/16 (same colors as EEVEE & Viewport, different colors for each column, but the colors fit well with a dark theme)
Core: https://projects.blender.org/blender/blender/projects/3
Render & Cycles: https://projects.blender.org/blender/blender/projects/13
Pipeline, Assets & IO: https://projects.blender.org/blender/blender/projects/10
Modeling: https://projects.blender.org/blender/blender/projects/7

The expected behavior would be that the background color for these columns matches to the other pages of the currently active dark theme (bthree-dark or gitea-dark). For bthree-dark, I would expect these colors to be at least `background-color: var(--color-project-board-bg) !important` or like the _EEVEE & Viewport_ / _User Interface_ pages, that the background colors of these columns be compatible with what we are used to see while using a "dark theme". To compare, here are the other project pages: - USD: https://projects.blender.org/blender/blender/projects/18 - Nodes & Physics: https://projects.blender.org/blender/blender/projects/9 - Grease Pencil: https://projects.blender.org/blender/blender/projects/6 - EEVEE & Viewport: https://projects.blender.org/blender/blender/projects/5 (this page is interesting because it features different columns, each one featuring colors that fit well with the current activated bthree-dark theme) - Sculpt, Paint & Texture: https://projects.blender.org/blender/blender/projects/14 - Compositing: https://projects.blender.org/blender/blender/projects/2 - Motion Tracking: https://projects.blender.org/blender/blender/projects/8 (this one shows empty columns and despite that state, their background color fits the current activated dark theme) - Python API: https://projects.blender.org/blender/blender/projects/12 - Video Sequencer: https://projects.blender.org/blender/blender/projects/17 - Platforms, Builds Tests & Devices: https://projects.blender.org/blender/blender/projects/11 - User Interface: https://projects.blender.org/blender/blender/projects/16 (same colors as EEVEE & Viewport, different colors for each column, but the colors fit well with a dark theme) - Core: https://projects.blender.org/blender/blender/projects/3 - Render & Cycles: https://projects.blender.org/blender/blender/projects/13 - Pipeline, Assets & IO: https://projects.blender.org/blender/blender/projects/10 - Modeling: https://projects.blender.org/blender/blender/projects/7

Bart van der Braak commented

2024-08-14 18:06:23 +02:00

I removed the specified colors, which also eliminated the white background.

Please take a look: Project | Animation & Rigging.

Is this the intended result, or have I misunderstood the issue?

I removed the specified colors, which also eliminated the white background. Please take a look: [Project | Animation & Rigging](https://projects.blender.org/blender/blender/projects/1). Is this the intended result, or have I misunderstood the issue?

👍 1

Sergey Sharybin commented

2024-08-14 18:08:00 +02:00

@pablovazquez Is it something you have experience with already?
On the one hand, if the module selects a fixed color, is not much we can do on our side. But is theming smart enough to avoid unreadable combinations (maybe hardcoded colors themselves are themable, and we can avoid unreadable combinations)? Could also be something for the upstream?

@pablovazquez Is it something you have experience with already? On the one hand, if the module selects a fixed color, is not much we can do on our side. But is theming smart enough to avoid unreadable combinations (maybe hardcoded colors themselves are themable, and we can avoid unreadable combinations)? Could also be something for the upstream?

xan2622 commented

2024-08-14 18:34:46 +02:00

I removed the specified colors, which also eliminated the white background.
Please take a look: Project | Animation & Rigging.
Is this the intended result, or have I misunderstood the issue?

Yes, this is the intended result. Thank you for fixing this CSS "issue".

> I removed the specified colors, which also eliminated the white background. > Please take a look: [Project | Animation & Rigging](https://projects.blender.org/blender/blender/projects/1). > Is this the intended result, or have I misunderstood the issue? Yes, this is the intended result. Thank you for fixing this CSS "issue".

Bart van der Braak added the

Type

Config

label 2024-08-14 18:36:29 +02:00

Bart van der Braak commented

2024-08-14 18:37:20 +02:00

Good to hear 👍

Will be closing this issue for now.

Good to hear 👍 Will be closing this issue for now.

Bart van der Braak closed this issue

2024-08-14 18:37:22 +02:00

Pablo Vazquez commented

2024-08-14 18:58:18 +02:00

This is not an issue, not a bug. It's the intended color that the modules pick. The problem is that Gitea doesn't let you pick colors for light/dark themes, it's just the one color hardcoded for the entire column.

@pablovazquez Is it something you have experience with already?
On the one hand, if the module selects a fixed color, is not much we can do on our side. But is theming smart enough to avoid unreadable combinations

No, unfortunately not. They literally background-color the selected RGB to the entire column. They even apply !important, even though they have a variable CSS for it var(--color-project-board-bg).

Could also be something for the upstream?

An easy fix would be to have the color for some part of the column.

Like the divider:

Or the background but not using 100% opacity, just 10% or so to blend with the background.

It'd be great for them to tackle this upstream. Using column background colors at the moment is hard to combine with theming.

This is not an issue, not a bug. It's the intended color that the modules pick. The problem is that Gitea doesn't let you pick colors for light/dark themes, it's just the one color hardcoded for the entire column. > @pablovazquez Is it something you have experience with already? > On the one hand, if the module selects a fixed color, is not much we can do on our side. But is theming smart enough to avoid unreadable combinations No, unfortunately not. They literally `background-color` the selected RGB to the entire column. They even apply `!important`, even though they have a variable CSS for it `var(--color-project-board-bg)`. ![important](/attachments/822ecf24-d175-4012-a763-87754e74eec3) > Could also be something for the upstream? An easy fix would be to have the color for _some_ part of the column. Like the divider: ![divider](/attachments/5d4ed0c5-c7f9-4fce-8b90-71043996dd1b) Or the background but not using 100% opacity, just 10% or so to blend with the background. ![blend](/attachments/7c84f743-4f6f-4eb0-bc5e-4531d1ee7b53) It'd be great for them to tackle this upstream. Using column background colors at the moment is hard to combine with theming.

image.png

82 KiB

image.png

203 KiB

image.png

6.5 KiB

👍 2

Sergey Sharybin commented

2024-08-14 19:40:01 +02:00

@pablovazquez Thanks for digging into it, makes sense!

Sign in to join this conversation.