Make issue/PR assignees and reviewers search by real name #14

New Issue

Sergey Sharybin · 2023-02-08T14:38:16+01:00

Sergey Sharybin commented

2023-02-08 14:38:16 +01:00

Currently the assignees and reviewers fields are limited to search by a user name, and does not consider the real user name. This makes it very hard to find people when you knwo person's name and don't know their nickname.

This works differently when you filter using the @ in the comment box which searches and visualzied both real and user name.

Currently the assignees and reviewers fields are limited to search by a user name, and does not consider the real user name. This makes it very hard to find people when you knwo person's name and don't know their nickname. This works differently when you filter using the `@` in the comment box which searches and visualzied both real and user name.

Sergey Sharybin added the

Service

Gitea

label 2023-02-08 14:38:16 +01:00

hestergong commented

2023-03-07 05:02:55 +01:00

Hi, I am trying to add this feature, and I found that in your custom/conf/app.ini file, if the flag DEFAULT_SHOW_FULL_NAME is set to true( reference to example configuration: app.example.ini ), then assignees and reviewers fields will become seached by fullname. I am not sure if this customization meets your requiment, or do you need both username and fullname to show, no matter what DEFAULT_SHOW_FULL_NAME flag is.

Hi, I am trying to add this feature, and I found that in your `custom/conf/app.ini` file, if the flag `DEFAULT_SHOW_FULL_NAME` is set to true( reference to example configuration: [`app.example.ini`](https://github.com/go-gitea/gitea/blob/757b4c17e900f1d11a81bc9467d90e6c245ee8f2/custom/conf/app.example.ini#L1238) ), then assignees and reviewers fields will become seached by fullname. I am not sure if this customization meets your requiment, or do you need both username and fullname to show, no matter what `DEFAULT_SHOW_FULL_NAME` flag is.

Sergey Sharybin commented

2023-03-07 09:21:18 +01:00

This option is probably indeed something we should consider using, even regardless of the assignees search.

@hestergong, am I right that when this option is enabled the assignees can only be looked up by real name when it is set?

This option is probably indeed something we should consider using, even regardless of the assignees search. @hestergong, am I right that when this option is enabled the assignees can only be looked up by real name when it is set?

hestergong commented

2023-03-07 10:00:12 +01:00

This option is probably indeed something we should consider using, even regardless of the assignees search.

@hestergong, am I right that when this option is enabled the assignees can only be looked up by real name when it is set?

Yes, if it is enabled, the search results in assignees and reviewers will only have realname, but not username.
We could add a feature that allows to search both username and realname no matter the option is enabled or not if the current behavior is not enough for your usage. @Sergey

> This option is probably indeed something we should consider using, even regardless of the assignees search. > > @hestergong, am I right that when this option is enabled the assignees can only be looked up by real name when it is set? Yes, if it is enabled, the search results in assignees and reviewers will only have realname, but not username. We could add a feature that allows to search both username and realname no matter the option is enabled or not if the current behavior is not enough for your usage. @Sergey

hestergong commented

2023-03-14 08:24:44 +01:00

Hi, please check this PR: https://github.com/go-gitea/gitea/pull/23463

👍 2

Brecht Van Lommel added the

Type

Deployment

label 2023-03-20 14:25:03 +01:00

Brecht Van Lommel commented

2023-03-20 14:28:49 +01:00

So this landed in Gitea main now, thanks!

I enabled DEFAULT_SHOW_FULL_NAME and merged main into the blender-merged develop branch. It's now waiting for the next time we rebuild and restart Gitea to start working.

So this landed in Gitea main now, thanks! I enabled `DEFAULT_SHOW_FULL_NAME` and merged `main` into the `blender-merged develop` branch. It's now waiting for the next time we rebuild and restart Gitea to start working.

❤️ 1

Brecht Van Lommel commented

2023-04-04 12:06:46 +02:00

This was deployed now.

Brecht Van Lommel closed this issue

2023-04-04 12:06:47 +02:00

Sign in to join this conversation.