Review state is temporaly incorrect when viewing file and return to pull request. #18

New Issue

Jeroen Bakker · 2023-02-09T10:18:08+01:00

Jeroen Bakker commented

2023-02-09 10:18:08 +01:00

It is an annoyance, but would make the review process better as it currently adds confusion. Especially when using the first time.

Steps to reproduce:

Start a review session on a pull request.
As we only see part of the files (diff) I often need to press view file to see surrounding context.
View file opens on the same tab.
Pressing back button to continue the review process will show the PR where no review process is active.
Pressing refresh page will show the review process again.

In short term would expect browser back button to show the correct process, or View file to open in a new tab. Of course the last can be done by holding an additional control/alt key.

In longer term it would be better to show more context around the diff.

It is an annoyance, but would make the review process better as it currently adds confusion. Especially when using the first time. Steps to reproduce: * Start a review session on a pull request. * As we only see part of the files (diff) I often need to press view file to see surrounding context. * View file opens on the same tab. * Pressing back button to continue the review process will show the PR where no review process is active. * Pressing refresh page will show the review process again. In short term would expect browser back button to show the correct process, or View file to open in a new tab. Of course the last can be done by holding an additional control/alt key. In longer term it would be better to show more context around the diff.

Jeroen Bakker changed title from ~~Review state is temporaly not correct when viewing file and return to pull request.~~ to Review state is temporaly incorrect when viewing file and return to pull request.

2023-02-09 10:22:39 +01:00

Brecht Van Lommel commented

2023-02-09 11:35:14 +01:00

The same kind of refresh issue happens when you e.g. apply a label to an issue, and then navigate back to the issue list. It will not show the new label being applied.

Brecht Van Lommel added the

bug

label 2023-02-09 11:55:10 +01:00

Brecht Van Lommel commented

2023-02-13 16:29:53 +01:00

After discussion with others involved in the Gitea migration, we are not planning to track general Gitea bugs ourselves unless they are critical bugs that block us from doing something. Otherwise we just end up replicating a part of the Gitea bug tracker. So this should be reported to the Gitea bug tracker.

It can be added to the list in #13.

After discussion with others involved in the Gitea migration, we are not planning to track general Gitea bugs ourselves unless they are critical bugs that block us from doing something. Otherwise we just end up replicating a part of the Gitea bug tracker. So this should be reported to the Gitea bug tracker. It can be added to the list in #13.

Brecht Van Lommel referenced this issue

2023-02-19 13:59:23 +01:00

Pull request features #13

Brecht Van Lommel closed this issue

2023-02-19 13:59:31 +01:00

Sign in to join this conversation.