Intermittent 500-errors on displaying commit #20

New Issue

Arnd Marijnissen · 2023-02-09T15:43:34+01:00

Arnd Marijnissen commented

2023-02-09 15:43:34 +01:00

We discovered that there is (at least) one commit which is giving intermittent 500-errors when loading it.

The commit in question is https://projects.blender.org/blender/blender/commit/05952aa94d

Correlating it with the gitea-log at the time of the request, it correlates with

2023/02/09 15:26:17 ...s/context/context.go:232:HTML() [E] [63e50284-25] Render failed: template: repo/diff/section_unified:28:29: executing "repo/diff/section_unified" at <$section.GetComputedInlineDiffFor>: error calling GetComputedInlineDiffFor: runti
me error: slice bounds out of range [2:1]

Note that the range ([2:1]) varies..

Grepping logs for 'GetComputedInlineDiffFor' or 'slice bounds' in the log gets 110 hits , but sometimes the error is in 'repo/diff/section_unified', sometimes in 'repo/diff/section_split'

@dr.sybren was quick to give me the line of code in the template related to the error:

{{$inlineDiff := $section.GetComputedInlineDiffFor $line $.root.locale -}}

Reloading the page most often results in a success, but once in 8-10 reloads it results in a 500-error with the following log-line in gitea.log.

We discovered that there is (at least) one commit which is giving intermittent 500-errors when loading it. The commit in question is https://projects.blender.org/blender/blender/commit/05952aa94d Correlating it with the gitea-log at the time of the request, it correlates with ``` 2023/02/09 15:26:17 ...s/context/context.go:232:HTML() [E] [63e50284-25] Render failed: template: repo/diff/section_unified:28:29: executing "repo/diff/section_unified" at <$section.GetComputedInlineDiffFor>: error calling GetComputedInlineDiffFor: runti me error: slice bounds out of range [2:1] ``` Note that the range ([2:1]) varies.. Grepping logs for 'GetComputedInlineDiffFor' or 'slice bounds' in the log gets 110 hits , but sometimes the error is in 'repo/diff/section_unified', sometimes in 'repo/diff/section_split' @dr.sybren was quick to give me the line of code in the template related to the error: ``` {{$inlineDiff := $section.GetComputedInlineDiffFor $line $.root.locale -}} ``` Reloading the page most often results in a success, but once in 8-10 reloads it results in a 500-error with the following log-line in gitea.log.

Brecht Van Lommel added the

Type

Bug

label 2023-02-09 16:15:01 +01:00

Philipp Oeser commented

2023-02-23 12:00:00 +01:00

Just had the 500 on this commit as well https://projects.blender.org/blender/blender/commit/eae36be372a6

Brecht Van Lommel commented

2023-12-01 19:05:44 +01:00

As far as I know this is not so much a problem anymore, at least not to the extent that we should be tracking it. It's always possible for some operation to take too long and time out, but I don't think there's any specific optimization here that is so important for us.

Brecht Van Lommel closed this issue

2023-12-01 19:05:44 +01:00

Sign in to join this conversation.