Buildbot: automated build for every pull request #44

New Issue

Brecht Van Lommel · 2023-02-27T18:04:28+01:00

Brecht Van Lommel commented

2023-02-27 18:04:28 +01:00

Currently developers can manually trigger builds with blender-bot, but ideally this would be automated so that fewer mistakes slip through and contributors can fix things before a reviewer has to get involved.

We can incrementally do a few things:

Add a lint builder that can quickly and safely run on all pull requests. This would check make format passes, and potentially other checks like clang-tidy.
Auto run builds for all PRs by authors with write access. This likely requires more machines on the buildbot to handle the load.
Auto run builds also for other contributors. This requires better isolation of the workers for security reasons.
Auto build GPU for changes to intern/cycles/kernel.

Currently developers can manually trigger builds with blender-bot, but ideally this would be automated so that fewer mistakes slip through and contributors can fix things before a reviewer has to get involved. We can incrementally do a few things: * [x] Add a lint builder that can quickly and safely run on all pull requests. This would check `make format` passes, and potentially other checks like `clang-tidy`. * [ ] Auto run builds for all PRs by authors with write access. This likely requires more machines on the buildbot to handle the load. * [ ] Auto run builds also for other contributors. This requires better isolation of the workers for security reasons. * [ ] Auto build GPU for changes to `intern/cycles/kernel`.

Brecht Van Lommel referenced this issue from blender/blender

2023-02-27 18:27:29 +01:00

Clang-format migration: Phabricator's Differential code review integration #60281

Brecht Van Lommel added the

buildbot

label 2023-02-27 18:53:10 +01:00

Ray molenkamp commented

2023-02-28 01:51:36 +01:00

Not sure if we have this level of control but any pulls for cycles should be building the GPU kernels, I know extra load, but with that many kernels, best to find out if a specific one has build issues sooner rather than later.

👍 1

Sign in to join this conversation.