Pull Request UI

Francesco Siddi commented

2023-02-08 12:17:18 +01:00

Owner

Pull request template
- Blender
- Add-ons
- Add-ons contrib
- Decide to leave reference out of pull request template or keep it
- Wrong empty reference when not specified in template
- Avoid superfluous "Description" title added when using text area
Cnvention for how to refer to pull requests in commit message
- Pull Request #123 at end of commit message
Check how to do existing rebase workflow (see #50 for configuration)
- Add PR # in rebase commit message (only last in the stack)
- Bug: when only Rebase then fast-forward button shows, command line instructions are different and say git merge -no-ff to always create a merge commit.
Ensure auto-closing works correctly
- Verify standard Fix #123: bugfix title works
- Auto close in release branches? Not possible to set multiple branches for auto close as in Phab. However it will auto close on merge to master, and for LTS specific bugs the issue could be set to reference the LTS branch, which seems enough.
- Bug: auto closing failing with branch reference in issue
- Auto closing does not change status tag to Resolved
Filter pull requests by project
Make the pull request status more visible from the list (whether it is accepted, has requested changes etc).
- This is a feature but only starts working when enabling branch protection, which seems like a bug (see TODO comment in GetApprovalCounts regarding official counts). But we need to enable branch protection anyway.
Ability to remove reviewers from pull request (use x button to Dismiss Review)
Bug: pull request page on original repo fails to render if pull requests are disabled on forked repo (upstream bug)
Default disable issues, PRs, wiki on forks? Could avoid some confusion.
Readability of diffs in dark themes is very bad (both arc-green and bthree-dark)
Create PR from single commit does not use commit message as description (upstream fix)
PR link not shown on push when pull requests are disabled on fork (upstream fix)

- [x] Pull request template - [x] Blender - [x] Add-ons - [x] Add-ons contrib - [x] Decide to leave reference out of pull request template or keep it - [x] Wrong empty reference when not specified in template - [x] Avoid superfluous "Description" title added when using text area - [x] Cnvention for how to refer to pull requests in commit message - `Pull Request #123` at end of commit message - [x] Check how to do existing rebase workflow (see #50 for configuration) - [x] Add PR # in rebase commit message (only last in the stack) - [x] Bug: when only `Rebase then fast-forward` button shows, command line instructions are different and say `git merge -no-ff` to always create a merge commit. - [x] Ensure auto-closing works correctly - [x] Verify standard `Fix #123: bugfix` title works - [x] Auto close in release branches? Not possible to set multiple branches for auto close as in Phab. However it will auto close on merge to master, and for LTS specific bugs the issue could be set to reference the LTS branch, which seems enough. - [x] Bug: auto closing failing with branch reference in issue - [x] Auto closing does not change status tag to Resolved - [x] Filter pull requests by project - [x] Make the pull request status more visible from the list (whether it is accepted, has requested changes etc). - This is a feature but only starts working when enabling branch protection, which seems like a bug (see TODO comment in `GetApprovalCounts` regarding official counts). But we need to enable branch protection anyway. - [x] Ability to remove reviewers from pull request (use x button to Dismiss Review) - [x] Bug: pull request page on original repo fails to render if pull requests are disabled on forked repo ([upstream bug](https://github.com/go-gitea/gitea/issues/20826)) - [x] Default disable issues, PRs, wiki on forks? Could avoid some confusion. - [x] Readability of diffs in dark themes is very bad (both arc-green and bthree-dark) - [x] Create PR from single commit does not use commit message as description ([upstream fix](https://github.com/go-gitea/gitea/pull/22629)) - [x] PR link not shown on push when pull requests are disabled on fork ([upstream fix](https://github.com/go-gitea/gitea/pull/22625))