Buildbot: Upgrade to latest HIP compiler on Windows #81
Labels
No Label
Service
Buildbot
Service
Chat
Service
Gitea
Service
Translate
Type
Bug
Type
Config
Type
Deployment
Type
Feature
Type
Setup
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/blender-projects-platform#81
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Previously the HIP compiler was available as a zip file that we could simply decompress. Now it is an installer, which will require some work in the provisioning scripts to automatically install.
I have found that running the installer creates a directory structure closely resembling the compressed zip files we used previously:
These commands created the directories
C:\Program Files\AMD\ROCm\5.5
andC:\Program Files\AMD\ROCm\5.7
, which have the same structure as our previous zipped packages, though with additional includes.I attempted to compile using one these versions (e.g by moving and renaming the 5.7 directory to
C:\Program Data\AMD\HIP\hip_sdk_5.7.32000
), but it appears CMAKE only setsHIP_ROOT_DIR
whenhip_sdk_5.5.30571
is available.I am investigating whether there is a misconfiguration in the provisioning scripts.
The HIP version is controlled by this file in the Blender repo:
https://projects.blender.org/blender/blender/src/branch/main/build_files/config/pipeline_config.yaml
The way I tested this in the past is to install HIP, then make a pull request for Blender with the updated version in this config file. And then it can be tested on the buildbot.
I guess you will also need to update this to only add the hip_sdk prefix for e.g. version 5.5 and older. Or alternatively rename all the existing folders to remove the prefix.
https://projects.blender.org/infrastructure/blender-devops/src/branch/main/buildbot/worker/blender/compile.py#L224
Thanks @brecht, that helps alot. I created blender/blender#122393
I was able to get a build going with the new version by executing
However, that did seem to give the following errors:
I am trying to figure out if this is an error on my part adding the new version and my expectation for it to work out of the box or that it's an issue with the package and/or the linked HIPRT version.
@brecht Do you think this error might be because HIPRT is not updated, or could there be another cause?
I noticed the new version of HIPRT available for download is packaged differently from the version we're currently using (
hiprtsdk-2.0.3a134c7
).Interestingly, there’s a more recent release on their GitHub page:
https://github.com/GPUOpen-LibrariesAndSDKs/HIPRT/releases/tag/2.3.7df94af
Yeah, I think it's a mismatch with the hiprt version somehow. We are in the process to switching to this new version, which is part of what prompted the upgrade.
I think from the infrastructure side just deploying this on all machines is enough. And then we can take care of solving these build errors and actually bumping the version in the blender repo config file.
Perfect, will do.
Summary of actions performed:
AMD-Software-PRO-Edition-23.Q4-Win10-Win11-For-HIP.exe
on Windows 10 VM and extracted the HIP 5.7.2 SDK./shared/devops/Software/Workers/windows/hip_sdk_5.7.32000.zip
.blender/blender
to target as patch on BuildBot (see here).cmd/provision/common/provision-hip.ps1
to include new version.pwsh -c "cmd/machine/machine-push-workers.ps1"
with:Machine-Push-Core-ToWorkers -machinePattern "*" -devOpsEnvIds "UATEST"
Machine-Push-Software-ToWorkers -machinePattern "*-windows-*" -devOpsEnvIds "UATEST"
pwsh -c "cmd/machine/machine-invoke-workers.ps1"
with:Machine-Remote-Invoke -machinePattern "*-windows-*" -devOpsEnvIds "UATEST" -script $installHIP
builder-uatest.blender.org
usingvexp-code-patch-windows-amd64
(see 46).develop
intomaster
onbdr-devops-core
.pwsh -c "cmd/machine/machine-push-workers.ps1"
with:Machine-Push-Core-ToWorkers -machinePattern "*" -devOpsEnvIds "PROD"
Machine-Push-Software-ToWorkers -machinePattern "*-windows-*" -devOpsEnvIds "PROD"
pwsh -c "cmd/machine/machine-invoke-workers.ps1"
with:Machine-Remote-Invoke -machinePattern "*-windows-*" -devOpsEnvIds "PROD" -script $installHIP
builder.blender.org
usingvexp-code-patch-windows-amd64
(see 5382).Upgrade to latest HIP compiler on Windowsto Buildbot: Upgrade to latest HIP compiler on Windows