Gitea: Gate timeout (504) when creating pull-requests #91

New Issue

Sergey Sharybin · 2024-07-05T14:52:53+02:00

Sergey Sharybin commented

2024-07-05 14:52:53 +02:00

Often creating pull-request will result in the 504 error. This is likely caused by some sub-optimal checks in Gitea. There is fix in the works for this, which needs some extra testing and deployment: https://github.com/blender/gitea/tree/fix-slow-check-many-files

There might be extra sources for the slowdown tough.

Often creating pull-request will result in the 504 error. This is likely caused by some sub-optimal checks in Gitea. There is fix in the works for this, which needs some extra testing and deployment: https://github.com/blender/gitea/tree/fix-slow-check-many-files There might be extra sources for the slowdown tough.

Sergey Sharybin changed title from ~~Gate timeout when creating pull-requests~~ to Gate timeout (504) when creating pull-requests

2024-07-05 14:53:12 +02:00

Bart van der Braak commented

2024-07-08 13:10:24 +02:00

I'm able to replicate the 504 issue on UATEST consistently;

Creating a new branch based off main (e.g. before-big-change)
Hard resetting it before commit 3be54248961, a commit that includes 1383 changed files with 0 additions and 19974 deletions
Commit a change to that branch
Try and create a pull request targeting main

Ref: https://uatest.projects.blender.org/bartvdbraak/blender/compare/main...before-big-change

I will test the optimizations Brecht suggested and try and add my own or involve the Gitea maintainers (e.g. Matti).

I'm able to replicate the 504 issue on UATEST consistently; 1. Creating a new branch based off `main` (e.g. `before-big-change`) 2. Hard resetting it before commit [3be54248961](https://projects.blender.org/blender/blender/commit/3be54248961), a commit that includes 1383 changed files with 0 additions and 19974 deletions 3. Commit a change to that branch 4. Try and create a pull request targeting `main` Ref: https://uatest.projects.blender.org/bartvdbraak/blender/compare/main...before-big-change <img width="954" alt="image" src="attachments/c9f3d483-ba7a-48f2-a948-25d5b2812643"> I will test [the optimizations Brecht suggested](https://github.com/blender/gitea/commit/1b4599ecd577e3ab30921b7ba64dbea2ad4f2adb) and try and add my own or involve the Gitea maintainers (e.g. Matti).

image.png

70 KiB

Bart van der Braak commented

2024-07-08 15:06:47 +02:00

Brecht's fix seems to have worked.

I didn't get a 504 while creating the Pull Request after building and releasing a new gitea version based on https://github.com/blender/gitea/tree/fix-slow-check-many-files, see https://uatest.projects.blender.org/bartvdbraak/blender/pulls/1

Brecht's fix seems to have worked. I didn't get a 504 while creating the Pull Request after building and releasing a new `gitea` version based on https://github.com/blender/gitea/tree/fix-slow-check-many-files, see https://uatest.projects.blender.org/bartvdbraak/blender/pulls/1

👍 1

Bart van der Braak commented

2024-07-15 11:26:23 +02:00

The fix for this issue has been cherry picked into blender-merged-develop (57f1c31) and tested on our Acceptance environment.

Brecht also created a PR (#31548) for this fix upstream, which has been backported to v1.22

After discussing deploying the change to production, we chose to wait until after the 4.2 release, therefor it's deployment is planned for this Wednesday (2024-07-17).

The fix for this issue has been cherry picked into `blender-merged-develop` ([57f1c31](https://github.com/blender/gitea/commit/57f1c317bef32763eb443412884015a98d92a802)) and tested on our Acceptance environment. Brecht also created a PR ([#31548](https://github.com/go-gitea/gitea/pull/31548)) for this fix upstream, which has been backported to v1.22 After discussing deploying the change to production, we chose to wait until after the 4.2 release, therefor it's deployment is planned for this Wednesday (2024-07-17).

👍 1

Bart van der Braak self-assigned this 2024-07-15 11:26:56 +02:00

Bart van der Braak added the due date 2024-07-17

2024-07-15 11:27:23 +02:00

Bart van der Braak added this to the DevOps Progress Board project 2024-07-16 12:48:33 +02:00

Bart van der Braak commented

2024-07-17 14:22:15 +02:00

Deployment was executed today at 13.00 CEST and completed at 13.05 CEST.

Everything went according to plan without any failures, a snapshot will be kept until tomorrow.

Deployment was executed today at 13.00 CEST and completed at 13.05 CEST. Everything went according to plan without any failures, a snapshot will be kept until tomorrow.

❤️ 1

Bart van der Braak closed this issue

2024-07-17 14:22:15 +02:00

Bart van der Braak changed title from ~~Gate timeout (504) when creating pull-requests~~ to Gitea: Gate timeout (504) when creating pull-requests

2024-07-17 15:15:53 +02:00

Sign in to join this conversation.