Favourite star doesn't work on speaker profile page #70846

New Issue

Sybren A. Stüvel · 2019-10-15T17:09:43+02:00

Sybren A. Stüvel commented

2019-10-15 17:09:43 +02:00

Favourite star doesn't seem to work on a speaker's profile page.

For example, I have Piere-Armand's talk favourited, but when visiting his profile page the star isn't filled in. Pressing it makes it filled-in, but refreshing the page makes it open again.

Favourite star doesn't seem to work on a speaker's profile page. For example, I have [Piere-Armand's talk](https://conference.blender.org/profile/879) favourited, but when visiting his profile page the star isn't filled in. Pressing it makes it filled-in, but refreshing the page makes it open again.

Sybren A. Stüvel commented

2019-10-15 17:09:43 +02:00

Added subscribers: @dr.sybren, @SemMulder, @fsiddi

Francesco Siddi commented

2019-10-15 17:43:12 +02:00

Could not find any logic in the following code:

button.favorite-star(
    onclick="favoriteStarToggle(event)"
    data-is-favorite=is_favorite,
    data-favorite-url="{% url 'presentation_favorite' year=event.edition.year pk=event.pk %}"
)

Can @SemMulder help?

Could not find any logic in the following code: ``` button.favorite-star( onclick="favoriteStarToggle(event)" data-is-favorite=is_favorite, data-favorite-url="{% url 'presentation_favorite' year=event.edition.year pk=event.pk %}" ) ``` Can @SemMulder help?

Sem Mulder was assigned by Francesco Siddi

2019-10-15 17:43:21 +02:00

Sem Mulder commented

2019-10-16 08:53:35 +02:00

There is an error in the template, will commit a fix soon. As a side note, why do this :'(?: https://docs.djangoproject.com/en/2.2/ref/templates/api/#how-invalid-variables-are-handled.