infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Gallery not visible when editing unapproved extension #102

New Issue
Closed
opened 2024-04-30 18:40:44 +02:00 by Dalai Felinto · 6 comments
Dalai Felinto commented 2024-04-30 18:40:44 +02:00
Owner
Copy Link

See: image

Related (but parallel to): #98

See: ![image](/attachments/936f27a9-b996-48da-8e28-8c67ff721d29) Related (but parallel to): https://projects.blender.org/infrastructure/extensions-website/issues/98
image.png
190 KiB
image.png
190 KiB
image.png
Anna Sirota commented 2024-05-09 18:22:51 +02:00
Owner
Copy Link

Gallery not visible when editing

Hm, this doesn't look like an Update or a Draft page.
It does look like either a broken Details page (which shouldn't show any images until they are approved), or a broken Approval Queue page.

Please describe what you expected to see and how you end up there (as a creator/moderator/etc.), and share the URL of the page.

> Gallery not visible when **editing** Hm, this doesn't look like an Update or a Draft page. It _does_ look like either a broken Details page (which shouldn't show **any** images until they are approved), or a broken Approval Queue page. Please describe what you expected to see and how you end up there (as a creator/moderator/etc.), and share the URL of the page.
Anna Sirota commented 2024-05-09 18:27:53 +02:00
Owner
Copy Link

looks more closely ah, this is definitely an Extension Details page, which you saw because you have a staff account.

Ideally, now that there's a separate page for moderators to view the unlisted extensions, this should have been a 404 regardless of whether you have a staff account or not.

_looks more closely_ ah, this is definitely an Extension Details page, which you saw because you have a staff account. Ideally, now that there's a separate page for moderators to view the unlisted extensions, this should have been a 404 regardless of whether you have a staff account or not.
Pablo Vazquez commented 2024-05-27 11:37:41 +02:00
Owner
Copy Link

I can't really tell if this has been fixed or no longer an issue?

I can't really tell if this has been fixed or no longer an issue?
Pablo Vazquez added the
Type
Report
 label 2024-05-27 12:50:15 +02:00
Dalai Felinto commented 2024-06-03 11:20:42 +02:00
Author
Owner
Copy Link

The problem is still there, but indeed I can only go there if I'm an admin otherwise I get a 404.
e.g., https://extensions.blender.org/add-ons/cloudrig/

I guess the bug is that this should be a 404 also for admins?

The problem is still there, but indeed I can only go there if I'm an admin otherwise I get a 404. e.g., https://extensions.blender.org/add-ons/cloudrig/ I guess the bug is that this should be a 404 also for admins?
Anna Sirota commented 2024-06-04 14:04:09 +02:00
Owner
Copy Link

Let's make it 404 for everyone to avoid confusion?

(This means it's not a 404 only when extension is approved.)

Let's make it 404 for everyone to avoid confusion? (This means it's not a 404 only when extension is approved.)
👍 1
Anna Sirota commented 2024-06-05 13:33:02 +02:00
Owner
Copy Link

Deployed along with 20240605-112418

Deployed along with [20240605-112418](https://projects.blender.org/infrastructure/extensions-website/releases/tag/20240605-112418)
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#102
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?