infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

Front-end: Permissions not showing on approval queue nor on extension detail #110

New Issue
Closed
opened 2024-05-03 19:09:22 +02:00 by Dalai Felinto · 0 comments
Dalai Felinto commented 2024-05-03 19:09:22 +02:00
Owner
Copy Link
  1. Upload nice_addon-2.0.0__network.zip
  2. Add a description and Submit for Approval
  3. Check the card on the approval queue, no permission information is shown there:

image

Comments from Pablo:

The review template (extensions_review_detail.html) extends detail.html, that has the permissions section inside the {% block extension_permissions %} block. Which is not overriden in the review template so permissions should show up.

I temporarily set "Files" permission for border-buddy, to be able to illustrate the problem in production:

1. Upload [nice_addon-2.0.0__network.zip](/attachments/64c95cf4-8640-4299-a451-a88ae30aafc7) 2. Add a description and Submit for Approval 3. Check the card on the approval queue, no permission information is shown there: ![image](/attachments/df753697-a164-4549-96b0-accc5713e6cf) ---------- Comments from Pablo: The review template (extensions_review_detail.html) extends detail.html, that has the permissions section inside the {% block extension_permissions %} block. Which is not overriden in the review template so permissions should show up. --------- I temporarily set "Files" permission for border-buddy, to be able to illustrate the problem in production: * https://extensions.blender.org/approval-queue/border-buddy/ * https://extensions.blender.org/add-ons/border-buddy/#permissions
nice_addon-2.0.0__network.zip
916 B
image.png
38 KiB
Dalai Felinto added the
Type
Bug
 label 2024-05-03 19:12:33 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
tokens-version-api
tokens
teams-support
filter-sort
production
api-speedup
api-icon-and-featured-image-url
tos-flatpage
fix-thumbnails-edit
more-logging-context
20240509-162312
20240509-160002
20240508-232058
20240508-221524
20240508-205611
20240425-132150
20240425-131144
20240425-102931
20240422-134616
20240422-084341
20240419-153008
20240419-150441
20240419-142636
20240419-103659
20240419-101459
20240419-091152
20240419-090459
20240418-155811
20240415-103440
20240411-125734
20240411-084629
20240405-171720
20240404-143833
20240404-073026
20240404-065215
20240402-155921
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#110
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?