Some valid tags break the submission, validation doesn't indicate which #123

New Issue

Márton Lente · 2024-05-10T15:53:49+02:00

Márton Lente commented

2024-05-10 15:53:49 +02:00

Context

When uploading a new extension, tags are read from the manifest file. There's a list of valid tags documented in the following manual, that the manifest file's tags must match: https://docs.blender.org/manual/en/dev/extensions/tags.html

Issue(s)

When submitting an add-on, some tags seems to be invalid despite being listed in the docs, and throw an error, for example 'Bake'.
The error shows a generic message, but doesn't indicate which tag is invalid. Finding out which tag is not working is only possible by trial and error:

Solution

All tags should be accepted that are listed in docs. The error message should show which tag(s) are invalid in the submitted manifest file.

Alternatively, a feature could be added to assign tags to add-ons and themes from a pre-defined list after the upload. (Editing tags post-upload is currently not possible).

## Context When uploading a new extension, tags are read from the manifest file. There's a list of valid tags documented in the following manual, that the manifest file's tags must match: https://docs.blender.org/manual/en/dev/extensions/tags.html ## Issue(s) - When submitting an add-on, some tags seems to be invalid despite being listed in the docs, and throw an error, for example _'Bake'_. - The error shows a generic message, but doesn't indicate which tag is invalid. Finding out which tag is not working is only possible by trial and error: ![some-valid-tags-break-the-submisson.png](/attachments/fa99aa1d-1eaf-4583-a3c6-a6e0d5abcc29) ## Solution All tags should be accepted that are listed in docs. The error message should show which tag(s) are invalid in the submitted manifest file. Alternatively, a feature could be added to assign tags to add-ons and themes from a pre-defined list after the upload. (Editing tags post-upload is currently not possible).

some-valid-tags-break-the-submisson.png

20 KiB

Márton Lente added the

labels 2024-05-10 15:53:50 +02:00

Oleg-Komarov referenced this issue from a commit

2024-05-13 14:41:00 +02:00

Validation: improve error message for tags and licenses #123

Oleg-Komarov referenced this issue from a commit

2024-05-13 15:25:44 +02:00

Add tag values in the historical migration #123

Oleg-Komarov commented

2024-05-13 15:26:38 +02:00

Pushed a fix for a better validation message.
The discrepancy between docs and dev setup is due to missing values in the migration. I've updated the migration - if a dev db is created from scratch, it will have all the values, but this solution is not sustainable long-term, since we may add more values in prod via admin.

Pushed a fix for a better validation message. The discrepancy between docs and dev setup is due to missing values in the migration. I've updated the migration - if a dev db is created from scratch, it will have all the values, but this solution is not sustainable long-term, since we may add more values in prod via admin.

👍 1

Oleg-Komarov closed this issue

2024-05-13 15:26:39 +02:00

Sign in to join this conversation.