Refactor Extension and Version: explicit constructors from File #191

Oleg-Komarov · 2024-06-18T18:24:49+02:00

Oleg-Komarov commented

2024-06-18 18:24:49 +02:00

This change solves a blocker for an upcoming drop of Version.file field:

calculating Extension.latest_version relied on having VersionFiles already
populated, but it was triggered on Version.save(), which happened before
the cross table could be populated.

One functional change is that a Version object is now created in
NewVersionView, immediately after the File is saved, and not in
NewVersionFinalizeView, as before.

Tests are rewritten to require only FileFactory, the Extension and Version
objects are created as it is done in the actual production code.
This loses a bit on the ergonomics of factories, but overall makes the state of
test objects more consistent, often simplifying the test code.

VersionFactory is no longer needed, and has been cleaned up.
ExtensionFactory is only used in construct_fake_notifications, and could also
be replaced with an in-memory object constructed manually.

This change solves a blocker for an upcoming drop of Version.file field: calculating `Extension.latest_version` relied on having `VersionFiles` already populated, but it was triggered on `Version.save()`, which happened before the cross table could be populated. One functional change is that a Version object is now created in NewVersionView, immediately after the File is saved, and not in NewVersionFinalizeView, as before. Tests are rewritten to require only FileFactory, the Extension and Version objects are created as it is done in the actual production code. This loses a bit on the ergonomics of factories, but overall makes the state of test objects more consistent, often simplifying the test code. VersionFactory is no longer needed, and has been cleaned up. ExtensionFactory is only used in construct_fake_notifications, and could also be replaced with an in-memory object constructed manually.

Oleg-Komarov force-pushed refactor-models from af9de1b851 to c90aa6d93c

2024-06-18 19:13:58 +02:00

Compare

Oleg-Komarov force-pushed refactor-models from c90aa6d93c to 6d8fd61b23

2024-06-18 19:50:21 +02:00

Compare

Oleg-Komarov added 1 commit 2024-06-20 12:25:54 +02:00

Merge branch 'main' into refactor-models 61525cc9c3

Oleg-Komarov added 1 commit 2024-06-20 12:37:02 +02:00

cleanup unused VersionFactory c6ba74c76d

Oleg-Komarov added 1 commit 2024-06-20 12:51:56 +02:00

add a check that uploaded file belongs to the current user 1df59f7a10

Oleg-Komarov changed title from ~~WIP: Refactor Extension and Version: explicit constructors from File~~ to Refactor Extension and Version: explicit constructors from File

2024-06-20 12:52:07 +02:00

Oleg-Komarov added 1 commit 2024-06-20 13:56:39 +02:00

cleanups 77fa0f9b05

Oleg-Komarov added 1 commit 2024-06-20 14:33:34 +02:00

remove the check, rely on FileForm behavior dce7a40241

Anna Sirota approved these changes 2024-06-20 14:38:56 +02:00

Anna Sirota left a comment

LGTM

Oleg-Komarov merged commit ac49e9d5f6 into main

2024-06-20 14:40:41 +02:00

Oleg-Komarov deleted branch refactor-models

2024-06-20 14:40:41 +02:00