Error 500 on creating a Theme #203

New Issue

Mik Fis · 2024-07-07T16:40:07+02:00

Mik Fis commented

2024-07-07 16:40:07 +02:00

Attempting to upload a theme extension, it uploaded but immediately showed error 500, then it actually added the new extension to my profile but when trying to edit it or open it, it gives me the rror 500 agian.

Attempting to upload a theme extension, it uploaded but immediately showed error 500, then it actually added the new extension to my profile but when trying to edit it or open it, it gives me the rror 500 agian. <img width="877" alt="image" src="attachments/501aa439-bc28-46b3-9b71-8a2c80bd85c5"> <img width="519" alt="image" src="attachments/854d97da-71b2-42ba-812b-5695e9f2288c"> <img width="606" alt="image" src="attachments/83179f0d-9aa9-4a77-aabb-fc796b659bca">

image.png

6.8 KiB

image.png

44 KiB

image.png

100 KiB

Mik Fis added the

labels 2024-07-07 16:40:08 +02:00

Oleg-Komarov commented

2024-07-07 21:25:36 +02:00

Hi @fismik, thank you for your report.

This is a bug in website manifest field validation: you have submitted a value without https:// scheme, and we haven't caught it. Now the page tries to render a link and some formatting code expects a properly formed url, but gets only a domain name and crashes.

Since I don't think it's possible for you to fix it from this state via the website, I've updated the field value in the DB, so the page will at least stop crashing.

You should be able to delete the problematic uploads (I've noticed that you've created 2 uploads) and re-upload a zip with a fixed manifest.

We will improve the validation to prevent this from happening again.

Hi @fismik, thank you for your report. This is a bug in `website` manifest field validation: you have submitted a value without `https://` scheme, and we haven't caught it. Now the page tries to render a link and some formatting code expects a properly formed url, but gets only a domain name and crashes. Since I don't think it's possible for you to fix it from this state via the website, I've updated the field value in the DB, so the page will at least stop crashing. You should be able to delete the problematic uploads (I've noticed that you've created 2 uploads) and re-upload a zip with a fixed manifest. We will improve the validation to prevent this from happening again.

Oleg-Komarov self-assigned this 2024-07-07 21:25:51 +02:00

Oleg-Komarov referenced this issue from a commit

2024-07-08 11:01:56 +02:00

Fix `website` validation in manifest (#203)

Oleg-Komarov commented

2024-07-08 11:07:22 +02:00

Deployed the validation fix in production.

@fismik now it shouldn't be possible to upload a manifest that causes these 500 errors. Please reopen this issue if you still get the same problem.

Deployed the validation fix in production. @fismik now it shouldn't be possible to upload a manifest that causes these 500 errors. Please reopen this issue if you still get the same problem.

Oleg-Komarov closed this issue

2024-07-08 11:07:22 +02:00

Sign in to join this conversation.