infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Not getting notifications for reviews on add-on that I didn't upload #212

New Issue
Closed
opened 2024-07-17 12:29:11 +02:00 by Nika Kutsniashvili · 5 comments
Nika Kutsniashvili commented 2024-07-17 12:29:11 +02:00
Copy Link

Bool Tool add-on was assigned to me by Dalai, I didn't upload it myself and I'm not getting notifications for its reviews. I'm getting notifications for others I uploaded

[Bool Tool](https://extensions.blender.org/add-ons/bool-tool/) add-on was assigned to me by Dalai, I didn't upload it myself and I'm not getting notifications for its reviews. I'm getting notifications for others I uploaded
Nika Kutsniashvili added the
Priority
Normal
Type
Report
 labels 2024-07-17 12:29:12 +02:00
Dalai Felinto commented 2024-07-18 11:56:44 +02:00
Owner
Copy Link

This is very strange. I will leave for the backend team to investigate.

For the records, what I did was:

  • Remove extension from the Community team.
  • Add Nika as maintainer.
  • Remove me as maintainer.
This is very strange. I will leave for the backend team to investigate. For the records, what I did was: * Remove extension from the Community team. * Add Nika as maintainer. * Remove me as maintainer.
Oleg-Komarov commented 2024-07-18 12:01:19 +02:00
Owner
Copy Link

I will take a look. There is code for handling that, but apparently it's lacking test coverage.

I will take a look. There is code for handling that, but apparently it's lacking test coverage.
Dalai Felinto commented 2024-07-18 12:08:20 +02:00
Owner
Copy Link

And for the records, this is the same procedure I did for several of other community add-ons.

And for the records, this is the same procedure I did for several of other community add-ons.
Oleg-Komarov self-assigned this 2024-07-18 12:39:15 +02:00
Oleg-Komarov commented 2024-07-19 14:27:17 +02:00
Owner
Copy Link

This should be fixed now: future maintainer changes via admin should setup follow objects correctly.
Notifications are not created retroactively. What's gone is gone.

I've ran a script (ensure_followers management command) to backfill all missing follow relations, it fixed 20 author follows (which were likely all missing due to this bug) and 7 reviewer follows (which were not expected, this needs more digging).

This should be fixed now: future maintainer changes via admin should setup `follow` objects correctly. Notifications are not created retroactively. What's gone is gone. I've ran a script (`ensure_followers` management command) to backfill all missing follow relations, it fixed 20 author follows (which were likely all missing due to this bug) and 7 reviewer follows (which were not expected, this needs more digging).
Oleg-Komarov commented 2024-07-19 14:40:46 +02:00
Owner
Copy Link

Ok, the missing 7 reviewer follows are all for extension authors.
Since authors technically create a comment in approval activity, they get subscribed with flag=reviewer as well.
Not sure how exactly those 7 got missed in the initial notification setup, but it doesn't happen anymore for new submissions.

Ok, the missing 7 reviewer follows are all for extension authors. Since authors technically create a comment in approval activity, they get subscribed with flag=reviewer as well. Not sure how exactly those 7 got missed in the initial notification setup, but it doesn't happen anymore for new submissions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Oleg-Komarov
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#212
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?