Resolved reviews are still visible #217

New Issue

Do I get it right that once an Abuse report for a rating is resolved, we always expect a rating to be deleted, and it shouldn't be provided as a choice in the resolving form?

Should a rating author be notified that their rating is deleted? I can imagine that if I notice my rating disappears without explanation, I'll create it again.

Checked via admin. Do I get it right that once an Abuse report for a rating is resolved, we always expect a rating to be deleted, and it shouldn't be provided as a choice in the resolving form? Should a rating author be notified that their rating is deleted? I can imagine that if I notice my rating disappears without explanation, I'll create it again.

Dalai Felinto commented

2024-07-19 11:32:23 +02:00

@Oleg-Komarov I think it is fine to hide it (and disregard for ranking), no need to delete. I think we want to keep a track record of this, no?

and it shouldn't be provided as a choice in the resolving form?

I don't understand what you mean here.

Should a rating author be notified that their rating is deleted? I can imagine that if I notice my rating disappears without explanation, I'll create it again.

I think we could ... but do we do what? show the resolve text? it is nice for the sake of clarity, but we need to be clear about it (from the UI so when you "resolve" you know that what you write is sent around).

How about this:

We send a notification mentioning that the review was upheld because it goes against the site policy and gives link to a pre-filled issue similar to how we do for teams, where the person can dispute/ask for clarifications.

@Oleg-Komarov I think it is fine to hide it (and disregard for ranking), no need to delete. I think we want to keep a track record of this, no? > and it shouldn't be provided as a choice in the resolving form? I don't understand what you mean here. > Should a rating author be notified that their rating is deleted? I can imagine that if I notice my rating disappears without explanation, I'll create it again. I think we could ... but do we do what? show the resolve text? it is nice for the sake of clarity, but we need to be clear about it (from the UI so when you "resolve" you know that what you write is sent around). --- How about this: We send a notification mentioning that the review was upheld because it goes against the [site policy](https://link) and gives link to a pre-filled [issue](https://projects.blender.org/infrastructure/extensions-website/issues) similar to how we do for teams, where the person can dispute/ask for clarifications.

Oleg-Komarov commented

2024-07-19 12:02:53 +02:00

I think it is fine to hide it (and disregard for ranking), no need to delete.

We don't have a model field to hide ratings now, but we can decide to add it:

on one hand, keeping history of bad reviews is useful only if we plan to act on that somehow, if not - it should fine to delete them;
on the other hand, keeping a rating hidden but not deleted will prevent the author from creating a new one (due to the uniqueness constraint), but this may be confusing UX-wise if we hide it from the author;
so, we can do it in a superficial shadow-ban style, i.e. the rating author still sees their rating on the rating page, but other people don't see it, it's not included in the overall rating calculation and doesn't count towards the number of ratings in the extension card.

and it shouldn't be provided as a choice in the resolving form?

I don't understand what you mean here.

Is there a case when a rating abuse report is resolved, but the rating is not deleted? If there's such a case, it needs to be possible for a moderator to make this choice in the form.

[...] show the resolve text?

No, I meant just to notify about the fact that a rating was deleted. Don't think that an appeal process is needed, to be honest.

If we do shadow-ban, we may not need to create a notification :)

> I think it is fine to hide it (and disregard for ranking), no need to delete. We don't have a model field to hide ratings now, but we can decide to add it: - on one hand, keeping history of bad reviews is useful only if we plan to act on that somehow, if not - it should fine to delete them; - on the other hand, keeping a rating hidden but not deleted will prevent the author from creating a new one (due to the uniqueness constraint), but this may be confusing UX-wise if we hide it from the author; - so, we can do it in a superficial shadow-ban style, i.e. the rating author still sees their rating on the rating page, but other people don't see it, it's not included in the overall rating calculation and doesn't count towards the number of ratings in the extension card. >> and it shouldn't be provided as a choice in the resolving form? > > I don't understand what you mean here. Is there a case when a rating abuse report is resolved, but the rating is not deleted? If there's such a case, it needs to be possible for a moderator to make this choice in the form. > [...] show the resolve text? No, I meant just to notify about the fact that a rating was deleted. Don't think that an appeal process is needed, to be honest. If we do shadow-ban, we may not need to create a notification :)

Oleg-Komarov commented

2024-07-22 10:39:03 +02:00

We don't have a model field to hide ratings now

This is not true, we have a status field, and can set it to STATUS_DISABLED.

> We don't have a model field to hide ratings now This is not true, we have a status field, and can set it to STATUS_DISABLED.

Oleg-Komarov self-assigned this 2024-07-22 10:39:08 +02:00

Oleg-Komarov commented

2024-07-22 12:19:05 +02:00

@dfelinto do we have a site policy page to link to in notifications?
https://extensions.blender.org/terms-of-service/ doesn't mention anything relevant now

@dfelinto do we have a site policy page to link to in notifications? https://extensions.blender.org/terms-of-service/ doesn't mention anything relevant now

Oleg-Komarov referenced this issue

2024-07-22 12:26:33 +02:00

Reject rating when an abuse report gets resolved #223

Oleg-Komarov commented

2024-07-22 13:27:04 +02:00

I've noticed that we display a rating to the author, even if it is not listed.
We just need to fix the badge, now it says "Awaiting approval", will reword it to "Rejected" (since we don't manually approve ratings at the moment).

Maybe it's easier to leave it at that, and not even send a notification:

This also means we don't have a site policy link at the moment. (But maybe good to have the rules published anyway)

I've noticed that we display a rating to the author, even if it is not listed. We just need to fix the badge, now it says "Awaiting approval", will reword it to "Rejected" (since we don't manually approve ratings at the moment). Maybe it's easier to leave it at that, and not even send a notification: ![image](/attachments/2a68fd97-e8d2-4242-bf21-300bcbcc24bf) This also means we don't have a site policy link at the moment. (But maybe good to have the rules published anyway)

image.png

12 KiB

Oleg-Komarov referenced this issue from a commit

2024-07-22 13:42:58 +02:00

Reject rating when an abuse report gets resolved (#223)

Oleg-Komarov commented

2024-07-22 13:53:23 +02:00

Deployed in production. All future abuse reports should automatically reject reported ratings (when resolved and not dismissed).
I've manually updated status for the rating in the original report via admin.

Deployed in production. All future abuse reports should automatically reject reported ratings (when resolved and not dismissed). I've manually updated status for the rating in the original report via admin.

Oleg-Komarov closed this issue

2024-07-22 13:53:23 +02:00

Sign in to join this conversation.