Retain order of approval queue when commenting all extensions #238

New Issue

Oane-Gros · 2024-08-23T09:17:45+02:00

Oane-Gros commented

2024-08-23 09:17:45 +02:00

Hi,
The comment to all extensions (switch to GPL-3) seems to have randomized the approval queue to when the general announcement was registered at each extension.

I don't know how easy it is to make these types of updates handle all Awaiting Review extensions in order in the future, but this may be nice. Or to have certain updates be excluded from the Activity but this seems like much more overhead.

Thanks :)

Hi, The comment to all extensions (switch to GPL-3) seems to have randomized the approval queue to when the general announcement was registered at each extension. I don't know how easy it is to make these types of updates handle all `Awaiting Review` extensions in order in the future, but this may be nice. Or to have certain updates be excluded from the `Activity` but this seems like much more overhead. Thanks :)

Oane-Gros added the

labels 2024-08-23 09:17:45 +02:00

Oane-Gros changed title from ~~Retain order of approval queue when updating all add-ons~~ to Retain order of approval queue when commenting all extensions

2024-08-23 09:47:55 +02:00

Oleg-Komarov self-assigned this 2024-08-23 10:11:26 +02:00

Oleg-Komarov commented

2024-08-23 10:19:16 +02:00

Hi, the approval queue page needed some attention either way - its initial implementation was a bit naive and the page was getting slower.

The performance fix would look involve keeping a materialized table that represents the queue - now we recompute all the data based on all the comments, and it's understandably getting slower with time.

While defining how this queue representation is updated, we can also fix the issue of regular comments bumping items in the queue. This means that only comments that change review status would be affecting the position in the queue.

Hi, the approval queue page needed some attention either way - its initial implementation was a bit naive and the page was getting slower. The performance fix would look involve keeping a materialized table that represents the queue - now we recompute all the data based on all the comments, and it's understandably getting slower with time. While defining how this queue representation is updated, we can also fix the issue of regular comments bumping items in the queue. This means that only comments that change review status would be affecting the position in the queue.

👍 1

Oane-Gros commented

2024-08-23 10:24:26 +02:00

That makes a lot of sense! The current system seems to also deincentivize making (small) changes to versions that are awaiting review because it will lose the spot in the Approval Queue, and this would then also be alleviated.

Oleg-Komarov referenced this issue from a commit

2024-08-23 13:32:20 +02:00

ApprovalQueue: use a materialized table

Oleg-Komarov referenced this issue

2024-08-23 13:32:33 +02:00

ApprovalQueue: use a materialized table #240

Oleg-Komarov referenced this issue from a commit

2024-08-23 15:11:47 +02:00

ApprovalQueue: use a materialized table (#240)

Oleg-Komarov commented

2024-08-23 15:21:28 +02:00

The fix is deployed in production.