Introduce Thumbnails for files #51

New Issue

Pablo Vazquez · 2024-03-05T12:33:52+01:00

Pablo Vazquez commented

2024-03-05 12:33:52 +01:00

At the moment images are always loaded in full size, making the site slow (right now the homepage has images of up to 2MB).

~~implement thumbnailing as in other projects (using sorl.thumbnail?)~~
Use thumbnails in cards
~~Use thumbnails in small versions of previews in Extension Detail~~ #100
Bug: videos are not working on the gallery since the introduction of thumbnails.
Use thumbnails in Extension Update template

At the moment images are always loaded in full size, making the site slow (right now the homepage has images of up to 2MB). * [ ] ~~implement thumbnailing as in other projects (using `sorl.thumbnail`?)~~ * [x] Use thumbnails in cards * [ ] ~~Use thumbnails in small versions of previews in Extension Detail~~ #100 * [ ] Bug: videos are not working on the gallery since the introduction of thumbnails. * [ ] Use thumbnails in Extension Update template

Pablo Vazquez added the

labels 2024-03-05 12:33:52 +01:00

Anna Sirota self-assigned this 2024-04-02 15:33:51 +02:00

Dalai Felinto referenced this issue

2024-04-08 11:50:51 +02:00

Extensions Website - Backend Road to Beta #70

Anna Sirota referenced this issue

2024-04-25 16:12:00 +02:00

Thumbnails for images and videos #87

Anna Sirota referenced this issue from a commit

2024-04-25 17:50:59 +02:00

Thumbnails for images and videos (#87)

Anna Sirota commented

2024-04-25 18:55:56 +02:00

Deployed thumbnails generation for images and videos both in staging and production.

About sorl: it's not used because we've had problems with its caching causing very high database I/O in Blender ID (so high it was discovered because it caused regular performance drops for other services) , even though Blender ID barely uses any images.
So, out of caution, I'd not use it in a new project that can be expected to have quite some traffic.

Thumbnails get generated in background tasks, and if no thumbnails exist, source image will be used instead (Sentry will log errors about this).

An annoying side-effect of this is that in development, ./manage.py process_tasks has to be run in order for thumbnails to be generated (same as with ClamAV scanning).

See more details in #87

Deployed thumbnails generation for images and videos both in staging and production. About `sorl`: it's not used because we've had problems with its caching causing very high database I/O in Blender ID (so high it was discovered because it caused regular performance drops for other services) , even though Blender ID barely uses any images. So, out of caution, I'd not use it in a new project that can be expected to have quite some traffic. Thumbnails get generated in background tasks, and if no thumbnails exist, source image will be used instead (Sentry will log errors about this). An annoying side-effect of this is that in development, `./manage.py process_tasks` has to be run in order for thumbnails to be generated (same as with `ClamAV` scanning). See more details in https://projects.blender.org/infrastructure/extensions-website/pulls/87

Pablo Vazquez commented

2024-04-25 19:01:42 +02:00

Great! Any reason to go with PNG instead of something like WebP? Or even jpeg.

Great! Any reason to go with PNG instead of something like [WebP](https://developers.google.com/speed/webp#:~:text=WebP%20lossless%20images%20are%2026,of%20just%2022%25%20additional%20bytes.)? Or even jpeg.

Anna Sirota commented

2024-04-25 19:16:18 +02:00

Not JPEG because I'd expect a lot of text on extensions previews, and JPEG compression doesn't handle text well.
As for WebP I forgot about it again tbh: is it good at compressing illustrations with text and other sharp-edged graphics on them, compared to PNG?
It's easy to change, if WebP is preferable

Not `JPEG` because I'd expect a lot of text on extensions previews, and `JPEG` compression doesn't handle text well. As for `WebP` I forgot about it again tbh: is it good at compressing illustrations with text and other sharp-edged graphics on them, compared to `PNG`? It's easy to change, if `WebP` is preferable

Sign in to join this conversation.