infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Introduce Thumbnails for files #51

New Issue
Closed
opened 2024-03-05 12:33:52 +01:00 by Pablo Vazquez · 4 comments
Pablo Vazquez commented 2024-03-05 12:33:52 +01:00
Owner
Copy Link

At the moment images are always loaded in full size, making the site slow (right now the homepage has images of up to 2MB).

  • implement thumbnailing as in other projects (using sorl.thumbnail?)
  • Use thumbnails in cards
  • Use thumbnails in small versions of previews in Extension Detail #100
  • Bug: videos are not working on the gallery since the introduction of thumbnails.
  • Use thumbnails in Extension Update template
At the moment images are always loaded in full size, making the site slow (right now the homepage has images of up to 2MB). * [x] ~~implement thumbnailing as in other projects (using `sorl.thumbnail`?)~~ * [x] Use thumbnails in cards * [x] ~~Use thumbnails in small versions of previews in Extension Detail~~ #100 * [x] Bug: videos are not working on the gallery since the introduction of thumbnails. * [x] Use thumbnails in Extension Update template
Pablo Vazquez added the
Type
Enhancement
Priority
Normal
 labels 2024-03-05 12:33:52 +01:00
Anna Sirota self-assigned this 2024-04-02 15:33:51 +02:00
Anna Sirota commented 2024-04-25 18:55:56 +02:00
Owner
Copy Link

Deployed thumbnails generation for images and videos both in staging and production.

About sorl: it's not used because we've had problems with its caching causing very high database I/O in Blender ID (so high it was discovered because it caused regular performance drops for other services) , even though Blender ID barely uses any images.
So, out of caution, I'd not use it in a new project that can be expected to have quite some traffic.

Thumbnails get generated in background tasks, and if no thumbnails exist, source image will be used instead (Sentry will log errors about this).

An annoying side-effect of this is that in development, ./manage.py process_tasks has to be run in order for thumbnails to be generated (same as with ClamAV scanning).

See more details in #87

Deployed thumbnails generation for images and videos both in staging and production. About `sorl`: it's not used because we've had problems with its caching causing very high database I/O in Blender ID (so high it was discovered because it caused regular performance drops for other services) , even though Blender ID barely uses any images. So, out of caution, I'd not use it in a new project that can be expected to have quite some traffic. Thumbnails get generated in background tasks, and if no thumbnails exist, source image will be used instead (Sentry will log errors about this). An annoying side-effect of this is that in development, `./manage.py process_tasks` has to be run in order for thumbnails to be generated (same as with `ClamAV` scanning). See more details in https://projects.blender.org/infrastructure/extensions-website/pulls/87
Pablo Vazquez commented 2024-04-25 19:01:42 +02:00
Author
Owner
Copy Link

Great! Any reason to go with PNG instead of something like WebP? Or even jpeg.

Great! Any reason to go with PNG instead of something like [WebP](https://developers.google.com/speed/webp#:~:text=WebP%20lossless%20images%20are%2026,of%20just%2022%25%20additional%20bytes.)? Or even jpeg.
Anna Sirota commented 2024-04-25 19:16:18 +02:00
Owner
Copy Link

Not JPEG because I'd expect a lot of text on extensions previews, and JPEG compression doesn't handle text well.
As for WebP I forgot about it again tbh: is it good at compressing illustrations with text and other sharp-edged graphics on them, compared to PNG?
It's easy to change, if WebP is preferable

Not `JPEG` because I'd expect a lot of text on extensions previews, and `JPEG` compression doesn't handle text well. As for `WebP` I forgot about it again tbh: is it good at compressing illustrations with text and other sharp-edged graphics on them, compared to `PNG`? It's easy to change, if `WebP` is preferable
Anna Sirota commented 2024-05-14 15:07:08 +02:00
Owner
Copy Link

Changed thumbnails format to WebP 6f07ae61b6

Changed thumbnails format to WebP https://projects.blender.org/infrastructure/extensions-website/commit/6f07ae61b6c09a60f8f1ff6b9f25fbe94a20a7be
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Anna Sirota
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#51
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?