infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

No template errors/403_csrf/html #56

New Issue
Closed
opened 2024-03-15 14:15:44 +01:00 by Dalai Felinto · 1 comment
Dalai Felinto commented 2024-03-15 14:15:44 +01:00
Owner
Copy Link

in the file common/views/errors.py the function csrf_failure tries to use a non-existing template: errors/403_csrf.html.

I wonder if we should just use template_name='common/error.html' instead.

The code where this was introduced never shipped with the template: 0c86ff5b13

in the file `common/views/errors.py` the function `csrf_failure` tries to use a non-existing template: `errors/403_csrf.html`. I wonder if we should just use template_name='common/error.html' instead. The code where this was introduced never shipped with the template: 0c86ff5b136f571701501080ddcec9252e2b11c6
Anna Sirota commented 2024-04-04 09:13:51 +02:00
Owner
Copy Link

We probably don't need a custom template for CSRF errors, yes.
Removed this override in 8ab3b4af05 .

We probably don't need a custom template for CSRF errors, yes. Removed this override in 8ab3b4af05be56e02c0e13834831265994388308 .
Anna Sirota self-assigned this 2024-04-04 09:17:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Anna Sirota
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#56
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?