Ratings: Implement replies #64
Labels
No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/extensions-website#64
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Allow extension creators to reply to ratings/reviews.
The system underneath apparently already allows it, judging by the
is_reply
property of ratings.I am assuming that this feature means implementing a single reply from maintainer to a given rating, not supporting a discussion thread in ratings, i.e. a rating reply can't be replied to.
Yes. So for example in case of a bad review the developer can explain or ask them to update because they fixed the issue or something like that. But no thread. We don’t want it to turn into a Q&A or support channel.
@pablovazquez or @martonlente could you please help me with rating reply display:
that's what I've done so far, and I don't like it too much:
the relevant code is here:
https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/components/rating.html#L55-L71
feel free to commit to that branch
also you might want to improve the reply form itself: https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/ratingreply_form.html
Nice addition, and I think it's a good starting point!
I can think of e.g. a nested box style display, similar to what we do on Studio, for example here, with some refinements. (Since there's only going to be one reply if any, we can make its design more attached / refined.)
If it's what we want, the input could also be moved to the rating box. This would also work if we want to make the single reply editable later. What do you think?
Yes, I think that's a good way to approach it.
Even if we don't implement inline editing and open a separate form page, making it look the same on different pages is good.
Regarding the actual style - I think nested box should work well, but I don't have a strong opinion on this either way.
Thanks for the feedback! I added some simple tweaks and 'normalization' what I found achievable within the templates' architecture:
ratings/components/rating.html
, so it can't be easily nested, but maybe it's better like below with an improved layout.Thanks, this looks good! I'll proceed with this for now, and we can get back to this once we decide to extend the features.
Deployed in production.