Ratings: Implement replies #64

Closed
opened 2024-03-25 14:27:00 +01:00 by Pablo Vazquez · 8 comments

Allow extension creators to reply to ratings/reviews.

The system underneath apparently already allows it, judging by the is_reply property of ratings.

Allow extension creators to reply to ratings/reviews. The system underneath apparently already allows it, judging by the `is_reply` property of ratings.
Pablo Vazquez added the
Type
Enhancement
Priority
Normal
labels 2024-03-25 14:27:01 +01:00
Oleg-Komarov self-assigned this 2024-06-10 15:06:44 +02:00
Owner

I am assuming that this feature means implementing a single reply from maintainer to a given rating, not supporting a discussion thread in ratings, i.e. a rating reply can't be replied to.

I am assuming that this feature means implementing a single reply from maintainer to a given rating, not supporting a discussion thread in ratings, i.e. a rating reply can't be replied to.
Author
Owner

I am assuming that this feature means implementing a single reply from maintainer to a given rating, not supporting a discussion thread in ratings, i.e. a rating reply can't be replied to.

Yes. So for example in case of a bad review the developer can explain or ask them to update because they fixed the issue or something like that. But no thread. We don’t want it to turn into a Q&A or support channel.

> I am assuming that this feature means implementing a single reply from maintainer to a given rating, not supporting a discussion thread in ratings, i.e. a rating reply can't be replied to. Yes. So for example in case of a bad review the developer can explain or ask them to update because they fixed the issue or something like that. But no thread. We don’t want it to turn into a Q&A or support channel.
Owner

@pablovazquez or @martonlente could you please help me with rating reply display:

that's what I've done so far, and I don't like it too much:
image

the relevant code is here:
https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/components/rating.html#L55-L71

feel free to commit to that branch

also you might want to improve the reply form itself: https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/ratingreply_form.html

@pablovazquez or @martonlente could you please help me with rating reply display: that's what I've done so far, and I don't like it too much: ![image](/attachments/5f56dd7a-693b-435d-a89b-46ce6c87a7a2) the relevant code is here: https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/components/rating.html#L55-L71 feel free to commit to that branch also you might want to improve the reply form itself: https://projects.blender.org/infrastructure/extensions-website/src/branch/rating-reply/ratings/templates/ratings/ratingreply_form.html

Nice addition, and I think it's a good starting point!

I can think of e.g. a nested box style display, similar to what we do on Studio, for example here, with some refinements. (Since there's only going to be one reply if any, we can make its design more attached / refined.)

If it's what we want, the input could also be moved to the rating box. This would also work if we want to make the single reply editable later. What do you think?

Nice addition, and I think it's a good starting point! I can think of e.g. a nested box style display, similar to what we do on Studio, for example [here](https://studio.blender.org/films/gold/gallery/?asset=7106#comment-12842), with some refinements. (Since there's only going to be one reply if any, we can make its design more attached / refined.) If it's what we want, the input could also be moved to the rating box. This would also work if we want to make the single reply editable later. What do you think?
Owner

This would also work if we want to make the single reply editable later.

Yes, I think that's a good way to approach it.
Even if we don't implement inline editing and open a separate form page, making it look the same on different pages is good.

Regarding the actual style - I think nested box should work well, but I don't have a strong opinion on this either way.

> This would also work if we want to make the single reply editable later. Yes, I think that's a good way to approach it. Even if we don't implement inline editing and open a separate form page, making it look the same on different pages is good. Regarding the actual style - I think nested box should work well, but I don't have a strong opinion on this either way.

Thanks for the feedback! I added some simple tweaks and 'normalization' what I found achievable within the templates' architecture:

  • The reply item display could be a simple nested box, with no avatar displayed, as it always belongs to the same user (author).
  • The reply form is appended to the review item in subject coming from ratings/components/rating.html, so it can't be easily nested, but maybe it's better like below with an improved layout.

ratings-replies-ui-1-min.jpeg
ratings-replies-ui-2-min.jpeg

Thanks for the feedback! I added some simple tweaks and 'normalization' what I found achievable within the templates' architecture: - The reply item display could be a simple nested box, with no avatar displayed, as it always belongs to the same user (author). - The reply form is appended to the review item in subject coming from `ratings/components/rating.html`, so it can't be easily nested, but maybe it's better like below with an improved layout. ![ratings-replies-ui-1-min.jpeg](/attachments/8ef6ee91-23b1-4616-a7ae-f9a2720d34d8) ![ratings-replies-ui-2-min.jpeg](/attachments/a6a287b5-c2ac-41ff-a334-122235a4e9ae)
Owner

Thanks, this looks good! I'll proceed with this for now, and we can get back to this once we decide to extend the features.

Thanks, this looks good! I'll proceed with this for now, and we can get back to this once we decide to extend the features.
Owner

Deployed in production.

Deployed in production.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#64
No description provided.