Moderation and approval queue: review data model and state transitions #89

New Issue

Oleg-Komarov · 2024-04-23T18:17:38+02:00

Oleg-Komarov commented

2024-04-23 18:17:38 +02:00

Current state

problems:
- approval-queue listing (AQ for short) doesn't indicate if a moderator requested changes
- once an extension is approved and listed, it becomes hidden in AQ, making it difficult to return to the corresponding approval thread (AT)
- confusing distinction and some code duplication between draft and manage extension/version pages:
  - after a draft is submitted it is possible to still edit the extension via the manage page;
  - also it is possible to save changes while the extension is still being reviewed, creating a scenario when a moderator may miss the latest change and approve the extension in an browser tab with outdated content
accepted by design:
- moderation is required only for an initial version, all subsequent versions are automatically marked as approved and become listed
- a user can notify moderators about a problem with a listed extension via an abuse report
- initial version submission generates a comment in AT with the "Awaiting Review" status (triggers a notification)

Relevant new features (full implementation may be out of scope)

new versions of a listed extension should create an comment on the AT (without triggering a notification)
when an upload (both for a draft an a listed extension) is marked as suspicious (FIleValidation not is_ok):
- it should be visible in AQ to moderators and admins (also triggers a notification)
- the AT should be hidden from the author and other users

Proposal on the structure

rewrite AQ page as a list of all ApprovalActivity items across all extensions, grouped by extension, display a summary:
- last meaningful status ("Awaiting review", "Awaiting changes")
- presence of a suspicious upload
- other fields present today (Type, Name, Author, Submitted, Activity)
make the role of Extension status (not ApprovalActivity!) "Awaiting Review" explicit:
- once a draft extension (status "Incomplete") is submitted for review, its status is changed to "Awaiting Review"
- saving changes while in "Awating Review" is either blocked or generates a comment on the AT
- when a moderator creates an "Awaiting Changes" ApprovalActivity item, the extension changes its status from "Awaiting Review" to "Incomplete", effectively returning it to a draft state

## Current state - problems: - approval-queue listing (AQ for short) doesn't indicate if a moderator requested changes - once an extension is approved and listed, it becomes hidden in AQ, making it difficult to return to the corresponding approval thread (AT) - confusing distinction and some code duplication between draft and manage extension/version pages: - after a draft is submitted it is possible to still edit the extension via the manage page; - also it is possible to save changes while the extension is still being reviewed, creating a scenario when a moderator may miss the latest change and approve the extension in an browser tab with outdated content - accepted by design: - moderation is required only for an initial version, all subsequent versions are automatically marked as approved and become listed - a user can notify moderators about a problem with a listed extension via an abuse report - initial version submission generates a comment in AT with the "Awaiting Review" status (triggers a notification) ## Relevant new features (full implementation may be out of scope) - new versions of a listed extension should create an comment on the AT (without triggering a notification) - when an upload (both for a draft an a listed extension) is marked as suspicious (FIleValidation not is_ok): - it should be visible in AQ to moderators and admins (also triggers a notification) - the AT should be hidden from the author and other users ## Proposal on the structure - rewrite AQ page as a list of all ApprovalActivity items across all extensions, grouped by extension, display a summary: - last meaningful status ("Awaiting review", "Awaiting changes") - presence of a suspicious upload - other fields present today (Type, Name, Author, Submitted, Activity) - make the role of Extension status (not ApprovalActivity!) "Awaiting Review" explicit: - once a draft extension (status "Incomplete") is submitted for review, its status is changed to "Awaiting Review" - saving changes while in "Awating Review" is either blocked or generates a comment on the AT - when a moderator creates an "Awaiting Changes" ApprovalActivity item, the extension changes its status from "Awaiting Review" to "Incomplete", effectively returning it to a draft state

Oleg-Komarov referenced this issue

2024-04-23 18:22:26 +02:00

Extensions Website - Backend Road to Beta #70

Oleg-Komarov referenced this issue

2024-04-29 18:46:10 +02:00

Refactor approval queue to display last meaningful status #94

Oleg-Komarov referenced this issue

2024-04-29 18:49:06 +02:00

Upload new version: generate approval activity item #95

Oleg-Komarov referenced this issue from a commit

2024-04-30 10:48:39 +02:00

Refactor approval queue to display last meaningful status (#94)

Oleg-Komarov referenced this issue from a commit

2024-04-30 10:49:06 +02:00

Upload new version: generate approval activity item (#95)

Oleg-Komarov commented

2024-05-03 12:04:22 +02:00

updates from https://devtalk.blender.org/t/2024-04-30-extensions-platform-backend/34413:

Approval Queue:

Sort by status (Awaiting Review, Awaiting Changes, Approved).
Create activity for image changes.
Don’t show status on the images.
When reporting a review, there is no need for “Versions” (aka Releases).

updates from https://devtalk.blender.org/t/2024-04-30-extensions-platform-backend/34413: Approval Queue: - [x] Sort by status (Awaiting Review, Awaiting Changes, Approved). - [ ] Create activity for image changes. - [x] Don’t show status on the images. - [x] When reporting a review, there is no need for “Versions” (aka Releases).

Oleg-Komarov referenced this issue from a commit

2024-05-03 12:08:34 +02:00

Approval queue: sort by status (#89)

Dalai Felinto commented

2024-05-03 12:22:50 +02:00

I thought that "Don’t show status on the images." was already tackled by 6ec4e31e24. Though I haven't tested it myself.

I thought that "Don’t show status on the images." was already tackled by https://projects.blender.org/infrastructure/extensions-website/commit/6ec4e31e24446356dc618fc94c4fc90cb19d6362. Though I haven't tested it myself.

👍 1

Oleg-Komarov commented

2024-05-10 15:35:35 +02:00

Closing this, as most of the things have been addressed, creating activity for extension changes (image uploads, description changes, etc) can be created as a separate more focused issue.

Oleg-Komarov closed this issue

2024-05-10 15:35:35 +02:00

Sign in to join this conversation.