infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

API: Upload new version of an extension #138

Merged
Dalai Felinto merged 12 commits from tokens-version-api into main 2024-05-27 16:18:05 +02:00
Conversation 8 Commits 12 Files Changed 7 +13 -11
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3b1cbdbb00 - Show all commits

24
extensions/views/api.py
View File

@ -7,6 +7,7 @@ from rest_framework.views import APIView
from rest_framework.permissions import IsAuthenticated from rest_framework.permissions import IsAuthenticated
from drf_spectacular.utils import OpenApiParameter, extend_schema from drf_spectacular.utils import OpenApiParameter, extend_schema
from django.core.exceptions import ValidationError from django.core.exceptions import ValidationError
from django.db import transaction
from common.compare import is_in_version_range, version from common.compare import is_in_version_range, version
from extensions.models import Extension, Platform, Version from extensions.models import Extension, Platform, Version
@ -207,18 +208,19 @@ class UploadExtensionVersionView(APIView):
if not form.is_valid(): if not form.is_valid():
return Response({'message': form.errors}, status=status.HTTP_400_BAD_REQUEST) return Response({'message': form.errors}, status=status.HTTP_400_BAD_REQUEST)
# Create the file instance with transaction.atomic():
file_instance = form.save(commit=False) # Create the file instance
file_instance.user = user file_instance = form.save(commit=False)
dfelinto marked this conversation as resolved Outdated
Oleg-Komarov commented 2024-05-21 12:32:26 +02:00
Outdated
Review
Copy Link

this save and the update_or_create below should ideally be together in the same transaction, we should wrap all db writes in one with transaction.atomic():

this save and the update_or_create below should ideally be together in the same transaction, we should wrap all db writes in one `with transaction.atomic():`
file_instance.save() file_instance.user = user
file_instance.save()
Oleg-Komarov commented 2024-05-27 15:59:10 +02:00
Review
Copy Link

btw, what's the use case for update here? why we are not just creating the object?

btw, what's the use case for update here? why we are not just creating the object?
Dalai Felinto commented 2024-05-27 16:12:56 +02:00
Review
Copy Link

I guess I was just copying the same code we used on UploadFileView.form_valid. Which probably should be changed as well.

Anyways, changing the PR to use create(), and will merge after testing.

I guess I was just copying the same code we used on UploadFileView.form_valid. Which probably should be changed as well. Anyways, changing the PR to use create(), and will merge after testing.
# Create the version from the file # Create the version from the file
version = Version.objects.update_or_create( version = Version.objects.update_or_create(
extension=extension, extension=extension,
file=file_instance, file=file_instance,
release_notes=release_notes, release_notes=release_notes,
**file_instance.parsed_version_fields, **file_instance.parsed_version_fields,
)[0] )[0]
return Response( return Response(
{ {