infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Multi-platform: support multiple files per version #201

Merged
Oleg-Komarov merged 43 commits from multi-os into main 2024-07-09 16:27:46 +02:00
Conversation 16 Commits 43 Files Changed 33 +12 -4
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3dd57566ff - Show all commits

10
extensions/signals.py
View File

@ -43,10 +43,18 @@ def _delete_versionfiles_file(
logger.info('Deleting File pk=%s of VersionFile pk=%s', file.pk, instance.pk) logger.info('Deleting File pk=%s of VersionFile pk=%s', file.pk, instance.pk)
file.delete() file.delete()
# this code is already quite convoluted
# TODO? maybe find some way to have a predictable order of deletion
try:
if instance.version.files.count() == 0: if instance.version.files.count() == 0:
# this was the last file, clean up the version # this was the last file, clean up the version
logger.info('Deleting Version pk=%s because its last file was deleted', instance.version.pk) logger.info(
'Deleting Version pk=%s because its last file was deleted',
instance.version.pk,
)
instance.version.delete() instance.version.delete()
except extensions.models.Version.DoesNotExist:
pass
@receiver(pre_save, sender=extensions.models.Extension) @receiver(pre_save, sender=extensions.models.Extension)