infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

ApprovalQueue: use a materialized table #240

Merged
Oleg-Komarov merged 4 commits from approval-queue-fix into main 2024-08-23 15:11:46 +02:00
Conversation 0 Commits 4 Files Changed 8 +14 -10
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9362feb2dd - Show all commits

24
reviewers/signals.py
View File

@ -52,17 +52,21 @@ def _update_approval_queue(
return return
if not created: if not created:
return return
if instance.type not in ApprovalActivity.STATUS_CHANGE_TYPES:
return
activity_count = ApprovalActivity.objects.filter(extension=instance.extension).count() activity_count = ApprovalActivity.objects.filter(extension=instance.extension).count()
ApprovalQueue.objects.update_or_create( if instance.type in ApprovalActivity.STATUS_CHANGE_TYPES:
extension=instance.extension, ApprovalQueue.objects.update_or_create(
defaults={ extension=instance.extension,
'activity_count': activity_count, defaults={
'latest_activity': instance, 'activity_count': activity_count,
'sortkey': instance.queue_sortkey, 'latest_activity': instance,
}, 'sortkey': instance.queue_sortkey,
) },
)
else:
if item := ApprovalQueue.objects.filter(extension=instance.extension).first():
item.activity_count = activity_count
item.save(update_fields={'activity_count'})
@receiver(pre_delete, sender=ApprovalActivity) @receiver(pre_delete, sender=ApprovalActivity)