infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Version Upload API: Handle \n for release notes #262

Merged
Dalai Felinto merged 2 commits from version-update-linebreak into main 2024-10-10 18:58:14 +02:00
Conversation 5 Commits 2 Files Changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 399f412e54 - Show all commits

4
extensions/views/api.py
View File

@ -174,8 +174,8 @@ class ExtensionVersionSerializer(serializers.Serializer):
def validate_release_notes(self, value): def validate_release_notes(self, value):
r"""Make sure \n and \r are valid after sanitation.""" r"""Make sure \n and \r are valid after sanitation."""
if not value: if value is None:
return value return
dfelinto marked this conversation as resolved Outdated
Francesco Siddi commented 2024-10-10 18:39:54 +02:00
Outdated
Review
Copy Link

why not a simple return?

why not a simple `return`?
Dalai Felinto commented 2024-10-10 18:46:25 +02:00
Outdated
Review
Copy Link

To make sure if we get None we still return None, if we get "" we still return "".

I will change this so it test for None instead.

To make sure if we get None we still return None, if we get "" we still return "". I will change this so it test for None instead.
return value.replace('\\n', '\n').replace('\\r', '\r') return value.replace('\\n', '\n').replace('\\r', '\r')