infrastructure/web-assets
1
4
Fork 3
Code Issues 3 Pull Requests 1 Projects Releases 41 Wiki Activity

Mismatching "danger" colours #94687

New Issue
Closed
opened 2022-01-06 13:04:24 +01:00 by Anna Sirota · 7 comments
Anna Sirota commented 2022-01-06 13:04:24 +01:00
Owner
Copy Link

Looks like there are two different colours in use for danger utility classes:

assets_shared/styles/_config.sass
50:  --color-danger: #EB5E28

and (probably from Bootstrap's $red variable):

.text-danger {
    color: #dc3545 !important;
}

which leads to Bootstrap formatted form errors looking like this, if var(--color-danger) is used together with text-danger class:

2022-01-06-130158_358x175_scrot.png

These should be the same color, probably dc3545.

Looks like there are two different colours in use for `danger` utility classes: ``` assets_shared/styles/_config.sass 50: --color-danger: #EB5E28 ``` and (probably from Bootstrap's `$red` variable): ``` .text-danger { color: #dc3545 !important; } ``` which leads to Bootstrap formatted form errors looking like this, if `var(--color-danger)` is used together with `text-danger` class: ![2022-01-06-130158_358x175_scrot.png](https://archive.blender.org/developer/F12791436/2022-01-06-130158_358x175_scrot.png) These should be the same color, probably `dc3545`.
Anna Sirota commented 2022-01-06 13:04:24 +01:00
Author
Owner
Copy Link

Added subscriber: @railla

Added subscriber: @railla
Philipp Oeser commented 2022-03-10 10:54:14 +01:00
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser commented 2022-03-10 10:54:14 +01:00
Copy Link

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Philipp Oeser commented 2022-03-10 10:54:14 +01:00
Copy Link

@railla is this an #infrastructure:_blender_web_assets internal TODO?
If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL to check specifically etc.).
If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED

@railla is this an #infrastructure:_blender_web_assets internal TODO? If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL to check specifically etc.). If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED
Aaron Carlisle commented 2022-03-10 17:40:08 +01:00
Contributor
Copy Link

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'
blender-admin commented 2022-10-10 18:03:16 +02:00
Copy Link

This issue was referenced by 56c569290e

This issue was referenced by 56c569290e6652dc15890a8440239f892783bcab
Pablo Vazquez commented 2022-10-10 18:03:31 +02:00
Owner
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Pablo Vazquez self-assigned this 2022-10-10 18:03:31 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Resolved

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Resolved
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Pablo Vazquez
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/web-assets#94687
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?