infrastructure/web-assets
1
4
Fork 3
Code Issues 3 Pull Requests 1 Projects Releases 41 Wiki Activity

Primary buttons have a reddish :focus colour #94688

New Issue
Closed
opened 2022-01-06 14:41:30 +01:00 by Anna Sirota · 8 comments
Anna Sirota commented 2022-01-06 14:41:30 +01:00
Owner
Copy Link

This is currently reproducible in the navbar at id.blender.org.

Not sure if this is intentional, but all buttons with white text have a reddish/pinkish focus colour, for example:

2022-01-06-143418_619x983_scrot.png

2022-01-06-144341_501x1070_scrot.png

(on the second screenshot button has btn-outline-secondary classes, at the moment of reporting this class wasn't part of BWA, so primary btn styles applied there too)

It might have something to do with how that colour is calculated in _utils.sass:

...
&:active, &:focus
	...
	color: hsl(hue($text-color), 100%, 85%)
This is currently reproducible in the navbar at id.blender.org. Not sure if this is intentional, but all buttons with white text have a reddish/pinkish focus colour, for example: ![2022-01-06-143418_619x983_scrot.png](https://archive.blender.org/developer/F12791545/2022-01-06-143418_619x983_scrot.png) ![2022-01-06-144341_501x1070_scrot.png](https://archive.blender.org/developer/F12791628/2022-01-06-144341_501x1070_scrot.png) (on the second screenshot button has `btn-outline-secondary` classes, at the moment of reporting this class wasn't part of BWA, so primary `btn` styles applied there too) It might have something to do with how that colour is calculated in `_utils.sass`: ``` ... &:active, &:focus ... color: hsl(hue($text-color), 100%, 85%) ```
Anna Sirota commented 2022-01-06 14:41:30 +01:00
Author
Owner
Copy Link

Added subscriber: @railla

Added subscriber: @railla
Philipp Oeser commented 2022-03-10 10:54:19 +01:00
Copy Link

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser commented 2022-03-10 10:54:19 +01:00
Copy Link

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'
Philipp Oeser commented 2022-03-10 10:54:19 +01:00
Copy Link

@railla is this an #infrastructure:_blender_web_assets internal TODO?
If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL/button to check specifically etc.).
If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED

@railla is this an #infrastructure:_blender_web_assets internal TODO? If this should pass the #triaging queue, it would be better to have exact repro steps also (which URL/button to check specifically etc.). If this should not pass the #triaging queue, it would be better to set subtype to TODO/DESIGN/... (default is REPORT which is associated with #triaging ) or set status to CONFIRMED
Anna Sirota commented 2022-03-10 11:01:39 +01:00
Author
Owner
Copy Link

@lichtwerk yes, this is an internal TODO, updated it (and others) to a relevant subtype.
my apologies, I keep forgetting that web-related tasks also end up in Triaging.

@lichtwerk yes, this is an internal TODO, updated it (and others) to a relevant subtype. my apologies, I keep forgetting that web-related tasks also end up in Triaging.
Pablo Vazquez commented 2022-07-14 16:36:08 +02:00
Owner
Copy Link

Added subscriber: @pablovazquez

Added subscriber: @pablovazquez
Pablo Vazquez commented 2022-07-14 16:36:08 +02:00
Owner
Copy Link

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'
Pablo Vazquez self-assigned this 2022-07-14 16:36:08 +02:00
Pablo Vazquez commented 2022-07-14 16:36:08 +02:00
Owner
Copy Link

This has been fixed a while back.

Thanks for the report!

This has been fixed a while back. Thanks for the report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Resolved

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Resolved
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Pablo Vazquez
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/web-assets#94688
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?