Richard Antalik iss
  • Joined on 2018-06-01
Richard Antalik merged pull request blender/blender#129610 2024-11-01 02:06:58 +01:00
Fix #129226: Retiming transition to faster speed does not work
Richard Antalik pushed to blender-v4.3-release at blender/blender 2024-11-01 02:06:58 +01:00
ba59908dc8 Fix #129226: Retiming transition to faster speed does not work
Richard Antalik deleted branch fix-small-retiming from iss/blender 2024-11-01 02:05:21 +01:00
Richard Antalik merged pull request blender/blender#129612 2024-11-01 02:05:16 +01:00
Fix: VSE: Retiming keys are drawn even if strip is too small
Richard Antalik pushed to blender-v4.3-release at blender/blender 2024-11-01 02:05:16 +01:00
d50d1e757b Fix #129583: Retiming controls are drawn even if strip is too small
Richard Antalik commented on pull request blender/blender#129612 2024-11-01 02:02:08 +01:00
Fix: VSE: Retiming keys are drawn even if strip is too small

Does this also properly hide retiming speed text label indicators when strip height is too small? (if so: yay, good!)

It does, will update commit message

Richard Antalik commented on pull request blender/blender#127239 2024-11-01 01:06:14 +01:00
VSE: Text editing in preview

Super cool to be able to edit text in the preview!

A couple of things I've noticed:

  • Pasting text from clipboard only inserts the text to the first line-break. The expected behavior…
Richard Antalik commented on issue blender/blender#129545 2024-11-01 00:46:10 +01:00
Breaking VFX & Video changes for 5.0

I am not sure what the anim_offs refers to, but the speed effect falls under the category that is superseded by retiming. It needs to go, and 5.0 is a good time for it.

It's called hold…

Richard Antalik commented on pull request blender/blender#129610 2024-11-01 00:34:01 +01:00
Fix #129226: Retiming transition to faster speed does not work

Yeah, the whole code needs bit more love. When I was working on #129305 I was hating every second of it :(

Richard Antalik commented on pull request blender/blender#129561 2024-11-01 00:25:59 +01:00
Fix #126007: Sequecer renders even if all videos are muted

This feels quite arbitrary, especially since the muted state can be animated.

Not sure if arbitrary. I read intent of original code as "if there is no video produced by sequencer, render…

Richard Antalik commented on pull request blender/blender#129562 2024-11-01 00:14:23 +01:00
Fix #129406: Crash on copy to selected for scene input property

While this fixes crash, it skips all the logic required to ensure caches and whatnot are invalidated? In a lot of other update functions are using Scene *scene = (Scene *)ptr->owner_id;. Is…

Richard Antalik commented on issue blender/blender#121260 2024-10-31 23:56:49 +01:00
Issue template design discussion

Yes, but I think, the problem we are facing is that endorsement may not be enough. You need to be rather loud. Perhaps I am not correct. It is hard to tell, since we did not test any of proposed…

Richard Antalik created pull request blender/blender#129659 2024-10-31 23:48:41 +01:00
Fix: VSE: Use after free in retiming
Richard Antalik created branch fix-use-free in iss/blender 2024-10-31 23:47:10 +01:00
Richard Antalik pushed to fix-use-free at iss/blender 2024-10-31 23:47:10 +01:00
a3d1e171e8 Fix: VSE: Use after free in retiming
Richard Antalik created pull request blender/blender#129612 2024-10-31 03:57:06 +01:00
Fix: VSE: Retiming keys are drawn even if strip is too small
Richard Antalik pushed to fix-small-retiming at iss/blender 2024-10-31 03:56:44 +01:00
74d5b26790 Fix: VSE: Retiming keys are drawn even if strip is too small
Richard Antalik created branch fix-small-retiming in iss/blender 2024-10-31 03:56:44 +01:00
Richard Antalik commented on issue blender/blender#128949 2024-10-31 03:03:16 +01:00
VSE fade in/out do not follow system setting with default interpolation type

Seems, that rna_FKeyframe_points_insert() explicitly ignores user preferences.

I think, that it is good idea to support specifying curve shape for fades, but I am not sure if preferences are…