Jason C. Wenger jcwenger
  • Joined on 2024-09-19
Jason C. Wenger deleted branch blender-v3.3-release from jcwenger/blender-test-data 2024-10-10 14:10:31 +02:00
Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 04:21:57 +02:00
Modeling: add support for merging triangles with reference to topology

My bad on the previous changes on monday -- I forgot to re-run the unit tests. Tested both manually, and auto, and also with the ifdefs for interactive debugging on.

Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 04:07:34 +02:00
Modeling: add support for merging triangles with reference to topology

I tested this in vertex/edge modes and it produces results that are (to me at least) intuitive, at least in the cases I tried. Do you have an example of it misbehaving to point me to what I was…

Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 04:00:04 +02:00
Modeling: add support for merging triangles with reference to topology

6fd0d448 I did the C style brace initializer, since all zeros is correct, and it was less overall code than switching to a class and writing a proper constructor. Let me know if you prefer it as…

Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 03:57:55 +02:00
Modeling: add support for merging triangles with reference to topology

e39ced2d Let me know if this wording is better. Tried to make it simpler and let the inline comments in the code fill in the details.

Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 03:56:43 +02:00
Modeling: add support for merging triangles with reference to topology

e1caee28 Silly mistake, sorry. I forgot to re-run the unit tests after I did some rebasing and fixed a merge conflict the wrong way.

Jason C. Wenger commented on pull request blender/blender#128610 2024-10-10 03:54:44 +02:00
Modeling: add support for merging triangles with reference to topology

f868bad3

I spent a while looking at this and can't come up with a good reason not to allow a true zero improvement. The minimum is removed and the test just says, "If it's less than zero, make…

Jason C. Wenger pushed to join-triangles-stateful at jcwenger/blender 2024-10-10 03:52:10 +02:00
e39ced2d35 Improve comments
2affd6d0a3 Add a few missing braces
fac9dde2f2 Move tagging code to main function
6fd0d4488e Init edge state. This is less code than writing a full constructor
f868bad3a0 Remove minimum improvement
Compare 8 commits »
Jason C. Wenger pushed to join-triangles-tmp at jcwenger/blender 2024-10-10 01:50:58 +02:00
1034f0e6de Fixes
Jason C. Wenger pushed to join-triangles-tmp at jcwenger/blender 2024-10-10 01:42:02 +02:00
946a04e27a Fixes
Jason C. Wenger pushed to join-triangles-tmp at jcwenger/blender 2024-10-10 01:17:01 +02:00
89749fc7ae Fix comment and test in ASSERT_VALID_ERROR_METRIC
Jason C. Wenger created branch join-triangles-tmp in jcwenger/blender 2024-10-10 01:17:01 +02:00