The changes look good. Great catch! Thanks for identifying this issue.
In general, this appears to work as expected. However, I'm running into a crash on Windows when running the Alab 2 scene with the combination Display Purpose: proxy + Material Purpose: preview
.…
The changes look good! I'll follow up with testing in the next day or so.
Oh I think I know what's up, try this: Play the animation in Blender at least once so all the simulation data from Geometry Nodes is "baked"/cached. Then do the USD export with Animation…
Hmm, there should be timeSamples for those? Basically the test has 4 different configurations: pointcloud1 which only varies the positions, pointcloud2 which only varies the velocity attribute,…
Tests for static point cloud export works great.
However, I'm a little confused why the animation time samples (for widths and positions) don't get saved when exporting the attached `usd_attribu…
My apologies for the delay reviewing this. The code changes look good to me as well, though I haven't had a chance to test the changes. I hope to do so in the next day or two, but I don't want to…
I agree it is surprising. It would be nice if this behavior could be fixed. I'd have to think about an improved name. It seems like accurately describing the current behavior invariably sounds…
In general this looks fine to me as well.
At first I was worried that this would break 'obdata instancing' (e.g. several Blender objects sharing the same mesh), but it appears that this…
@deadpin @makowalski would you know if
libusd_ms.so
interacts with the sound systems (SDL and/or pulse) in any way?
Not that I'm aware, but I don't know for sure. For what it's worth,…
@deadpin Thanks so much for the review!
The AbstractHierarchyIterator
exports instancer objects as the parents of the instances they generate, which explains the double transform. This may…
I'm not sure what's going on, either, but will keep thinking about it. In the meantime, making the context argument a reference with the ref()
call is probably an improvement, anyway, so that…