Looks good and works well. One question: I looked for an API on SdfPath that would append 2 absolute paths like
/rootand/Plane/Planeinto the form we need here but it looks like that…
I agree with @deadpin that we shouldn't be adding schemas as part of the import. Having the "SkelBindingAPI" for skeletons has been a requirement in USD for some time now (I can't remember in…
This PR seems to work great with data coming out of Blender (.blend attached for what I used), but I noticed some "incorrect" hierarchies in both ALab and 4004 Moore Lane demo files. I…
Just a question that occurred to me: is convert_scene_units redundant in this case? I.e., would it be sufficient to just have meters_per_unit set appropriately in io_usd.cc and use that to compute the scale? I know this would change some of the logic elsewhere to determine whether to apply scaling by checking if meters_per_unit is close to 1.0, so there are tradeoffs with either approach.
I think this conditional should be
Minor point: the help for the Custom option is "Specify a custom scene scale value". However, the custom value is actually in meters-per-unit. Would it be better to be consistent? I.e., either have the help for all the menu items be in meters-per-unit, or have the Custom option be a scene scale? The former option (using meters-per-unit for all items) would probably be less work and might fit better with the USD conventions. Again, this might not be an important issue.
Just FYI, I retargeted this PR to main and it should be ready to merge. Thanks.
e0feabe2c3
Merge branch 'main' of projects.blender.org:blender/blender into usd_import_merge_multiple_children
@lichtwerk @deadpin I'm not sure whether we want to merge this into main or the 4.2 release at this point. I will leave that up to others to decide. As noted above, changes in structure like…