The change looks good. Thanks for the fix!
NOTE: When testing the example in #124102 it turns out that this fix by coincidence exacerbates the name collision issue I noted in #124263. I.e., the multiple round trip Blender -> USD ->…
Update to PR:
Clean up prim merging logic:
merge_with_parent()
has been renamed can_merge_with_parent()
and the function no longer calls set_use_parent_xform()
on the prim.
This…
@lichtwerk I have WIP progress for a proposed fix: blender/blender#124153
However, I personally would not recommend making this change for the 4.2 release at…
@lichtwerk This is work in progress on a proposed fix.
Arm also taking a quick look into making a tweak to collect_readers
to handle this case. I will report what I find.
@deadpin for visibility.
I have an idea of what is going on and will look more into this on Friday, as I will be out Thursday.
However, in my humble opinion, the fix started in !124041,…
My apologies: pxr::SdfPath::TokenizeIdentifier()
is actually not the utility function I was thinking of. It's a function in stringUtils.h
:
#include <pxr/base/tf/stringUtils.h>
st…